mirror of
https://gitea.com/gitea/act
synced 2026-05-01 01:27:48 +02:00
f923badec7
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
147 lines
3.0 KiB
YAML
147 lines
3.0 KiB
YAML
version: "2"
|
|
output:
|
|
sort-order:
|
|
- file
|
|
linters:
|
|
default: none
|
|
enable:
|
|
- bidichk
|
|
- bodyclose
|
|
- contextcheck
|
|
- depguard
|
|
- dupl
|
|
- errcheck
|
|
- gocheckcompilerdirectives
|
|
- gocritic
|
|
- gocyclo
|
|
- gosec
|
|
- govet
|
|
- importas
|
|
- ineffassign
|
|
- misspell
|
|
- mirror
|
|
- modernize
|
|
- nakedret
|
|
- nolintlint
|
|
- perfsprint
|
|
- revive
|
|
- staticcheck
|
|
- unconvert
|
|
- unused
|
|
- usestdlibvars
|
|
- usetesting
|
|
- wastedassign
|
|
- whitespace
|
|
settings:
|
|
depguard:
|
|
rules:
|
|
main:
|
|
deny:
|
|
- pkg: github.com/pkg/errors
|
|
desc: Please use "errors" package from standard library
|
|
- pkg: gotest.tools/v3
|
|
desc: Please keep tests unified using only github.com/stretchr/testify
|
|
- pkg: log
|
|
desc: Please keep logging unified using only github.com/sirupsen/logrus
|
|
gocyclo:
|
|
min-complexity: 15
|
|
gocritic:
|
|
disabled-checks:
|
|
- ifElseChain
|
|
importas:
|
|
alias:
|
|
- pkg: github.com/sirupsen/logrus
|
|
alias: log
|
|
- pkg: github.com/stretchr/testify/assert
|
|
alias: assert
|
|
nolintlint:
|
|
allow-unused: false
|
|
require-explanation: true
|
|
require-specific: true
|
|
revive:
|
|
severity: error
|
|
rules:
|
|
- name: blank-imports
|
|
- name: constant-logical-expr
|
|
- name: context-as-argument
|
|
- name: context-keys-type
|
|
- name: dot-imports
|
|
- name: empty-lines
|
|
- name: error-return
|
|
- name: error-strings
|
|
- name: exported
|
|
- name: identical-branches
|
|
- name: if-return
|
|
- name: increment-decrement
|
|
- name: modifies-value-receiver
|
|
- name: package-comments
|
|
- name: redefines-builtin-id
|
|
- name: superfluous-else
|
|
- name: time-naming
|
|
- name: unexported-return
|
|
- name: var-declaration
|
|
- name: var-naming
|
|
staticcheck:
|
|
checks:
|
|
- all
|
|
- -ST1003
|
|
- -ST1005
|
|
- -QF1001
|
|
- -QF1006
|
|
- -QF1008
|
|
usetesting:
|
|
os-temp-dir: true
|
|
perfsprint:
|
|
concat-loop: false
|
|
govet:
|
|
enable:
|
|
- nilness
|
|
- unusedwrite
|
|
exclusions:
|
|
generated: lax
|
|
presets:
|
|
- comments
|
|
- common-false-positives
|
|
- legacy
|
|
- std-error-handling
|
|
rules:
|
|
- linters:
|
|
- bodyclose
|
|
- dupl
|
|
- errcheck
|
|
- gosec
|
|
- staticcheck
|
|
path: _test\.go
|
|
- linters:
|
|
- gosec
|
|
text: 'G115:'
|
|
- linters:
|
|
- gosec
|
|
text: 'G117:'
|
|
paths:
|
|
- report
|
|
issues:
|
|
max-issues-per-linter: 0
|
|
max-same-issues: 0
|
|
formatters:
|
|
enable:
|
|
- gci
|
|
- gofumpt
|
|
settings:
|
|
gci:
|
|
custom-order: true
|
|
sections:
|
|
- standard
|
|
- prefix(github.com/nektos/act)
|
|
- blank
|
|
- default
|
|
gofumpt:
|
|
extra-rules: true
|
|
exclusions:
|
|
generated: lax
|
|
paths:
|
|
- report
|
|
|
|
run:
|
|
timeout: 10m
|