mirror of
https://gitea.com/gitea/act_runner
synced 2026-09-21 19:37:07 +02:00
silverwind
19afebc53f
Container jobs on a Docker bridge network isolated from the runner's cache server now upload artifacts to Gitea directly instead of timing out, with a job log warning on how to make the cache reachable. Fixes https://gitea.com/gitea/runner/issues/1211 Reviewed-on: https://gitea.com/gitea/runner/pulls/1225 Reviewed-by: bircni <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io>
85 lines
3.7 KiB
Go
85 lines
3.7 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package container
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/netip"
|
|
"testing"
|
|
"time"
|
|
|
|
cerrdefs "github.com/containerd/errdefs"
|
|
"github.com/moby/moby/api/types/container"
|
|
"github.com/moby/moby/api/types/network"
|
|
mobyclient "github.com/moby/moby/client"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestIsolatedNetwork(t *testing.T) {
|
|
ctx := context.Background()
|
|
cache, lan := netip.MustParseAddr("172.18.0.3"), netip.MustParseAddr("192.168.1.20")
|
|
client := &mockDockerClient{}
|
|
client.On("ContainerList", ctx, mobyclient.ContainerListOptions{}).Return(mobyclient.ContainerListResult{Items: []container.Summary{{}, {
|
|
NetworkSettings: &container.NetworkSettingsSummary{Networks: map[string]*network.EndpointSettings{
|
|
"compose": {NetworkID: "c0ffee", IPAddress: cache},
|
|
"lan": {NetworkID: "beef", IPAddress: lan},
|
|
}},
|
|
}}}, nil)
|
|
for ref, inspected := range map[string]network.Network{
|
|
"c0ffee": {ID: "c0ffee", Name: "compose", Driver: "bridge"},
|
|
"beef": {ID: "beef", Name: "lan", Driver: "macvlan"},
|
|
"c0f": {ID: "c0ffee"},
|
|
"jobs": {ID: "f00d"},
|
|
} {
|
|
client.On("NetworkInspect", ctx, ref, mobyclient.NetworkInspectOptions{}).
|
|
Return(mobyclient.NetworkInspectResult{Network: network.Inspect{Network: inspected}}, nil)
|
|
}
|
|
check := func(addr netip.Addr, jobNetwork, want string) {
|
|
got, err := isolatedNetwork(ctx, client, addr, jobNetwork)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, want, got, jobNetwork)
|
|
}
|
|
check(cache, "", "compose")
|
|
check(cache, "jobs", "compose")
|
|
check(cache, "c0f", "")
|
|
check(cache, "host", "")
|
|
check(lan, "", "")
|
|
check(netip.MustParseAddr("10.0.0.5"), "", "")
|
|
}
|
|
|
|
func TestIsAddressPoolExhausted(t *testing.T) {
|
|
assert.True(t, isAddressPoolExhausted(cerrdefs.ErrInvalidArgument.WithMessage("Error response from daemon: all predefined address pools have been fully subnetted")))
|
|
assert.True(t, isAddressPoolExhausted(errors.New("could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network")))
|
|
assert.False(t, isAddressPoolExhausted(cerrdefs.ErrInvalidArgument.WithMessage("invalid subnet 10.0.0.0/8: it overlaps with an existing network")))
|
|
}
|
|
|
|
// Of this runner's networks, only the ones nothing is attached to and old enough to predate
|
|
// any job now starting are the runner's to reclaim. An unexpected NetworkRemove fails the
|
|
// test on its own, since testify has no expectation to match it against.
|
|
func TestRemoveOrphanNetworks(t *testing.T) {
|
|
ctx := context.Background()
|
|
cutoff := time.Date(2026, time.April, 29, 20, 0, 0, 0, time.UTC)
|
|
client := &mockDockerClient{}
|
|
client.On("NetworkList", ctx, mobyclient.NetworkListOptions{
|
|
Filters: make(mobyclient.Filters).Add("label", runnerUUIDLabel+"=runner-1"),
|
|
}).Return(mobyclient.NetworkListResult{Items: []network.Summary{
|
|
{ID: "orphan"},
|
|
{ID: "busy"},
|
|
{ID: "starting"},
|
|
}}, nil)
|
|
client.On("NetworkInspect", ctx, "orphan", mobyclient.NetworkInspectOptions{}).
|
|
Return(mobyclient.NetworkInspectResult{}, nil)
|
|
client.On("NetworkInspect", ctx, "busy", mobyclient.NetworkInspectOptions{}).
|
|
Return(mobyclient.NetworkInspectResult{Network: network.Inspect{Containers: map[string]network.EndpointResource{"c": {}}}}, nil)
|
|
client.On("NetworkInspect", ctx, "starting", mobyclient.NetworkInspectOptions{}).
|
|
Return(mobyclient.NetworkInspectResult{Network: network.Inspect{Network: network.Network{Created: cutoff.Add(time.Second)}}}, nil)
|
|
client.On("NetworkRemove", ctx, "orphan", mobyclient.NetworkRemoveOptions{}).
|
|
Return(mobyclient.NetworkRemoveResult{}, nil)
|
|
|
|
require.NoError(t, removeOrphanNetworks(ctx, client, "runner-1", cutoff))
|
|
client.AssertExpectations(t)
|
|
}
|