mirror of
https://gitea.com/gitea/act_runner
synced 2026-09-21 19:37:07 +02:00
Updates `gitea.dev/actionslib` to v1.0.0, see https://gitea.com/gitea/actionslib/pulls/17: 1. First-party expression parser passing GitHub's full conformance suite, replacing actionlint 1. Expression results match GitHub, including truthiness, numbers, `fromJSON`, `toJSON` and `hashFiles` cache keys 1. Whole-value `${{ }}` works for `strategy`, `env`, `with`, `services` and `outputs` 1. Matrix validation matches GitHub --------- Co-authored-by: bircni <bircni@icloud.com> Reviewed-on: https://gitea.com/gitea/runner/pulls/1221 Reviewed-by: bircni <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io>
122 lines
3.5 KiB
Go
122 lines
3.5 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.dev/actionslib/pkg/model"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.yaml.in/yaml/v4"
|
|
)
|
|
|
|
func TestMaxParallelStrategy(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
maxParallelString string
|
|
expectedMaxParallel int
|
|
}{
|
|
{
|
|
name: "max-parallel-1",
|
|
maxParallelString: "1",
|
|
expectedMaxParallel: 1,
|
|
},
|
|
{
|
|
name: "max-parallel-2",
|
|
maxParallelString: "2",
|
|
expectedMaxParallel: 2,
|
|
},
|
|
{
|
|
name: "max-parallel-default",
|
|
maxParallelString: "",
|
|
expectedMaxParallel: 4,
|
|
},
|
|
{
|
|
name: "max-parallel-10-clamped-to-combinations",
|
|
maxParallelString: "10",
|
|
expectedMaxParallel: 5,
|
|
},
|
|
{
|
|
name: "max-parallel-invalid-falls-back-to-default",
|
|
maxParallelString: "tow",
|
|
expectedMaxParallel: 4,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
matrix := map[string][]any{
|
|
"version": {1, 2, 3, 4, 5},
|
|
}
|
|
|
|
var rawMatrix yaml.Node
|
|
err := rawMatrix.Encode(matrix)
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
|
|
job := &model.Job{
|
|
Strategy: &model.Strategy{
|
|
MaxParallelString: tt.maxParallelString,
|
|
RawMatrix: rawMatrix,
|
|
},
|
|
}
|
|
|
|
matrixes, err := job.GetMatrixes()
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.NotNil(t, matrixes)
|
|
assert.Len(t, matrixes, 5)
|
|
assert.Equal(t, tt.expectedMaxParallel, maxParallelFor(job.Strategy, len(matrixes)))
|
|
})
|
|
}
|
|
|
|
t.Run("deferred strategy", func(t *testing.T) {
|
|
workflow, err := model.ReadWorkflow(strings.NewReader(`
|
|
jobs:
|
|
test:
|
|
if: false
|
|
strategy: ${{ fromJSON('{"max-parallel":2,"fail-fast":false,"matrix":{"os":["ubuntu","windows"]}}') }}
|
|
`))
|
|
require.NoError(t, err)
|
|
job := workflow.Jobs["test"]
|
|
rawStrategy := model.CloneYamlNode(job.RawStrategy)
|
|
require.NoError(t, (&runnerImpl{config: &Config{}}).NewPlanExecutor(&model.Plan{Stages: []*model.Stage{{Runs: []*model.Run{{Workflow: workflow, JobID: "test"}}}}})(t.Context()))
|
|
require.NotNil(t, job.Strategy)
|
|
assert.False(t, job.Strategy.GetFailFast())
|
|
assert.Equal(t, 2, maxParallelFor(job.Strategy, 5))
|
|
matrixes, err := job.GetMatrixes()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, []map[string]any{{"os": "ubuntu"}, {"os": "windows"}}, matrixes)
|
|
assert.Equal(t, rawStrategy, job.RawStrategy)
|
|
})
|
|
}
|
|
|
|
func TestNewPlanExecutorInvalidMatrix(t *testing.T) {
|
|
var rawMatrix yaml.Node
|
|
require.NoError(t, rawMatrix.Encode(map[string]any{
|
|
"config": map[string]any{"nested": "value"},
|
|
}))
|
|
|
|
plan := &model.Plan{Stages: []*model.Stage{{Runs: []*model.Run{{
|
|
Workflow: &model.Workflow{Jobs: map[string]*model.Job{
|
|
"test": {Strategy: &model.Strategy{RawMatrix: rawMatrix}},
|
|
}},
|
|
JobID: "test",
|
|
}}}}}
|
|
runner := &runnerImpl{config: &Config{}}
|
|
|
|
require.ErrorContains(t, runner.NewPlanExecutor(plan)(t.Context()), "could not get job matrix:")
|
|
|
|
for _, strategy := range []string{
|
|
`${{ fromJSON('invalid') }}`,
|
|
`${{ '${{ inputs.unresolved }}' }}`,
|
|
} {
|
|
t.Run(strategy, func(t *testing.T) {
|
|
workflow, err := model.ReadWorkflow(strings.NewReader("jobs:\n test:\n strategy: " + strategy))
|
|
require.NoError(t, err)
|
|
require.Error(t, runner.NewPlanExecutor(&model.Plan{Stages: []*model.Stage{{Runs: []*model.Run{{Workflow: workflow, JobID: "test"}}}}})(t.Context()))
|
|
})
|
|
}
|
|
}
|