mirror of
https://gitea.com/gitea/act_runner
synced 2026-11-08 10:57:59 +01:00
Contains a number of small bug fixes where jobs behaved differently from GitHub or failed silently.
1. Hooks fail on a refused `::set-env::` or `::add-path::` and no longer inherit the last step's identity
1. Docker build, exec and wait errors are returned instead of swallowed, token-only registry credentials work, logs of `--tty` services decode
1. Env files split lines like GitHub on each OS, so a carriage return is kept on Linux and CRLF ends a line on Windows, empty heredoc names or delimiters are rejected
1. Post steps run after their pre step even when main was skipped, composites see undeclared inputs, `runs.args` wins without `with.args` being parsed
1. Docker actions skip evaluating defaults of inputs given in `with` and read `entryPoint` and `args` in any case, a lowercase `dockerfile` is found, undeclared inputs get GitHub's warning
1. A user-set `CI` is kept, `GITHUB_REPOSITORY_ID` and the other missing `GITHUB_*` variables are exported
1. `timeout-minutes` can read the step's own `env`, a step-level `ACTIONS_ALLOW_UNSECURE_COMMANDS: false` beats a job-level `true` while the runner's own opt-in still wins, `pwsh` quotes the script path
1. A step `env:` given as one expression such as `${{ fromJSON(matrix.env) }}` is applied, `hashFiles` fails with GitHub's messages on script errors and after 120 seconds, a job image without node still gets an empty hash
1. A step whose command files cannot be reset fails instead of importing stale ones, a timeout between steps fails the job instead of reporting success
1. One named volume can be mounted at several paths, host-mode PTY steps keep their last output when they fail, host scratch directories are removed when job setup fails
1. Cancelling a step right after it starts kills its whole process tree
1. Cache prefix restores pick the newest entry created within the same second, also on S3, cache commits with a wrong size are rejected
1. Artifact chunks are written at their offset, download URLs are escaped, listing a run without artifacts no longer crashes
1. Poll backoff reaches `fetch_interval_max`, proxy passwords are masked in more forms, secrets are also masked in step names and in their quoted form in the runner log, a failed final report is logged
1. On Windows hosts a differently cased unsecure-commands opt-in or proxy variable counts, and an early cancel no longer leaks a job object handle
1. Interactive `register` prompts for a missing token and stops on SIGTERM, `exec --list --detect-event` no longer panics without events, `config set` works on `cache.s3` keys
Reviewed-on: https://gitea.com/gitea/runner/pulls/1338
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
177 lines
4.6 KiB
Go
177 lines
4.6 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// Copyright 2026 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.com/gitea/runner/act/common"
|
|
"gitea.com/gitea/runner/act/common/logging"
|
|
|
|
"gitea.dev/actionslib/pkg/model"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
yaml "go.yaml.in/yaml/v4"
|
|
)
|
|
|
|
func TestRunScriptGroupTitle(t *testing.T) {
|
|
sr := &stepRun{Step: &model.Step{Name: "Build"}}
|
|
assert.Equal(t, "make build", sr.runScriptGroupTitle("make build"))
|
|
assert.Equal(t, "echo one", sr.runScriptGroupTitle(" \techo one\necho two"))
|
|
assert.Equal(t, "Build", sr.runScriptGroupTitle(""))
|
|
|
|
sr = &stepRun{Step: &model.Step{ID: "s1"}}
|
|
assert.Equal(t, "s1", sr.runScriptGroupTitle("\n \n"))
|
|
}
|
|
|
|
func TestStepDeclaredEnvOrderPreservesYAML(t *testing.T) {
|
|
raw := `id: s1
|
|
run: "echo 1"
|
|
env:
|
|
GITHUB_TOKEN: tok
|
|
PATH: /custom/bin
|
|
MY_VAR: hello
|
|
`
|
|
var step model.Step
|
|
require.NoError(t, yaml.Unmarshal([]byte(raw), &step))
|
|
assert.Equal(t, []string{"GITHUB_TOKEN", "PATH", "MY_VAR"}, stepDeclaredEnvKeysInOrder(&step))
|
|
}
|
|
|
|
func TestStepDeclaredEnvKeysInOrderEmpty(t *testing.T) {
|
|
assert.Nil(t, stepDeclaredEnvKeysInOrder(nil))
|
|
assert.Empty(t, stepDeclaredEnvKeysInOrder(&model.Step{}))
|
|
}
|
|
|
|
func TestStepDeclaredEnvKeysIgnoreYAMLMergeKey(t *testing.T) {
|
|
doc := `
|
|
common: &common
|
|
COMMON_A: a
|
|
COMMON_B: b
|
|
step:
|
|
env:
|
|
LOCAL_BEFORE: before
|
|
<<: *common
|
|
COMMON_B: overridden
|
|
LOCAL_AFTER: after
|
|
`
|
|
var root struct {
|
|
Step model.Step `yaml:"step"`
|
|
}
|
|
require.NoError(t, yaml.Unmarshal([]byte(doc), &root))
|
|
|
|
keys := stepDeclaredEnvKeysInOrder(&root.Step)
|
|
assert.Equal(t, []string{"LOCAL_BEFORE", "COMMON_B", "LOCAL_AFTER"}, keys)
|
|
}
|
|
|
|
func TestPrintRunScriptActionDetailsGolden(t *testing.T) {
|
|
raw := `id: s1
|
|
name: Build
|
|
run: |
|
|
echo one
|
|
echo two
|
|
shell: pwsh
|
|
env:
|
|
PATH_PREFIX: /custom/bin
|
|
GITHUB_TOKEN: tok
|
|
GREETING: hello
|
|
`
|
|
var step model.Step
|
|
require.NoError(t, yaml.Unmarshal([]byte(raw), &step))
|
|
|
|
buf := &bytes.Buffer{}
|
|
logger := logging.New(logging.NewLevelHandler(newJobLogHandler(buf, cyan), logging.LevelInfo))
|
|
entry := logger.With("job", "j1")
|
|
ctx := common.WithLogger(t.Context(), entry)
|
|
|
|
sr := &stepRun{
|
|
Step: &step,
|
|
RunContext: &RunContext{},
|
|
shellCommand: `pwsh -command ". '{0}'"`,
|
|
interpolatedScript: "echo one\necho two\n",
|
|
env: map[string]string{
|
|
"PATH_PREFIX": "/custom/bin",
|
|
"GITHUB_TOKEN": "tok",
|
|
"GREETING": "hello",
|
|
},
|
|
}
|
|
|
|
sr.printRunScriptActionDetails(ctx)
|
|
|
|
want := strings.Join([]string{
|
|
"[j1] | ::group::Run echo one",
|
|
"[j1] | echo one",
|
|
"[j1] | echo two",
|
|
`[j1] | shell: pwsh -command ". '{0}'"`,
|
|
"[j1] | env:",
|
|
"[j1] | PATH_PREFIX: /custom/bin",
|
|
"[j1] | GREETING: hello",
|
|
"[j1] | ::endgroup::",
|
|
"",
|
|
}, "\n")
|
|
assert.Equal(t, want, buf.String())
|
|
}
|
|
|
|
func TestPrintRunActionHeaderGolden(t *testing.T) {
|
|
raw := `id: s1
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: "0"
|
|
token: secret
|
|
env:
|
|
CUSTOM: value
|
|
GITHUB_TOKEN: tok
|
|
`
|
|
var step model.Step
|
|
require.NoError(t, yaml.Unmarshal([]byte(raw), &step))
|
|
|
|
buf := &bytes.Buffer{}
|
|
logger := logging.New(logging.NewLevelHandler(newJobLogHandler(buf, cyan), logging.LevelInfo))
|
|
entry := logger.With("job", "j1")
|
|
ctx := common.WithLogger(t.Context(), entry)
|
|
|
|
printRunActionHeader(ctx, &step, map[string]string{"CUSTOM": "value", "GITHUB_TOKEN": "tok"}, &RunContext{})
|
|
|
|
want := strings.Join([]string{
|
|
"[j1] | ::group::Run actions/checkout@v4",
|
|
"[j1] | with:",
|
|
"[j1] | fetch-depth: 0",
|
|
"[j1] | token: secret",
|
|
"[j1] | env:",
|
|
"[j1] | CUSTOM: value",
|
|
"",
|
|
}, "\n")
|
|
assert.Equal(t, want, buf.String())
|
|
}
|
|
|
|
func TestIsInternalEnvKey(t *testing.T) {
|
|
for _, k := range []string{"PATH", "HOME", "CI", "GITHUB_TOKEN", "GITEA_ACTIONS", "RUNNER_OS", "INPUT_FOO"} {
|
|
assert.True(t, isInternalEnvKey(k, false), k)
|
|
}
|
|
for _, k := range []string{"PATH_PREFIX", "MY_VAR", "GREETING", "HOMEPAGE"} {
|
|
assert.False(t, isInternalEnvKey(k, false), k)
|
|
}
|
|
assert.True(t, isInternalEnvKey("path", true))
|
|
assert.False(t, isInternalEnvKey("path", false))
|
|
}
|
|
|
|
func TestPrintColoredScriptLineCyan(t *testing.T) {
|
|
f := textFormatter{w: io.Discard, color: cyan}
|
|
record := logging.Record{
|
|
Level: logging.LevelInfo,
|
|
Message: "echo one",
|
|
Attrs: []logging.Attr{
|
|
{Key: "job", Value: "j1"},
|
|
{Key: rawOutputField, Value: true},
|
|
{Key: scriptLineCyanField, Value: true},
|
|
},
|
|
}
|
|
buf := &bytes.Buffer{}
|
|
f.printColored(buf, record)
|
|
assert.Equal(t, "\x1b[36m|\x1b[0m \x1b[36;1mecho one\x1b[0m", buf.String())
|
|
}
|