From 0096f4b9855d873b48eba1eedc2a2b41324f1aa5 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Thu, 14 Jan 2021 11:19:02 -0500 Subject: [PATCH] ipa-kdb: Change mspac base RID logic from OR to AND The purpose is to set a default if the RID doesn't match expectations. Discovered by coverity Signed-off-by: Rob Crittenden Reviewed-By: Robbie Harwood Reviewed-By: Alexander Bokovoy --- daemons/ipa-kdb/ipa_kdb_mspac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c index 07c433e14..6202d3031 100644 --- a/daemons/ipa-kdb/ipa_kdb_mspac.c +++ b/daemons/ipa-kdb/ipa_kdb_mspac.c @@ -906,7 +906,7 @@ static krb5_error_code ipadb_get_pac(krb5_context kcontext, } /* IPA user principals are all constructed */ - if ((pac_info.logon_info.info->info3.base.rid != 515) || + if ((pac_info.logon_info.info->info3.base.rid != 515) && (pac_info.logon_info.info->info3.base.rid != 516)) { pac_upn.upn_dns_info.flags |= PAC_UPN_DNS_FLAG_CONSTRUCTED; }