From 08f2db78555ff1da56122c58275680fd98916c4d Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Thu, 29 Jul 2021 13:51:55 +0300 Subject: [PATCH] pylint: Fix no-member Teach pylint or skip newly exposed no-members. Fixes: https://pagure.io/freeipa/issue/9117 Signed-off-by: Stanislav Levin Reviewed-By: Rob Crittenden --- ipatests/test_ipalib/test_backend.py | 2 ++ ipatests/test_ipalib/test_config.py | 5 +++++ ipatests/test_ipalib/test_frontend.py | 2 ++ pylint_plugins.py | 31 +++++++++++++++++++++++---- 4 files changed, 36 insertions(+), 4 deletions(-) diff --git a/ipatests/test_ipalib/test_backend.py b/ipatests/test_ipalib/test_backend.py index 0bac1a503..b587029e3 100644 --- a/ipatests/test_ipalib/test_backend.py +++ b/ipatests/test_ipalib/test_backend.py @@ -83,8 +83,10 @@ class test_Connectible(ClassChecker): assert o.connect(*args, **kw) is None conn = context.example assert type(conn) is Connection + # pylint: disable=no-member assert o.args == args assert o.kw == kw + # pylint: enable=no-member assert conn.conn == 'The connection.' assert conn.disconnect == o.disconnect diff --git a/ipatests/test_ipalib/test_config.py b/ipatests/test_ipalib/test_config.py index ad24c9a6c..02d845c52 100644 --- a/ipatests/test_ipalib/test_config.py +++ b/ipatests/test_ipalib/test_config.py @@ -403,12 +403,15 @@ class test_Env(ClassChecker): assert o._merge_from_file(good) == (6, 6) added = ('string', 'null', 'yes', 'no', 'number', 'floating') assert list(o) == sorted(keys + added) + + # pylint: disable=no-member assert o.string == 'Hello world!' assert o.null is None assert o.yes is True assert o.no is False assert o.number == 42 assert o.floating == '3.14' + # pylint: enable=no-member def new(self, in_tree=False): """ @@ -573,10 +576,12 @@ class test_Env(ClassChecker): assert o.in_server is True assert o.logdir == home.join('.ipa', 'log') assert o.log == home.join('.ipa', 'log', 'server.log') + # pylint: disable=no-member assert o.yes is True assert o.no is False assert o.number == 42 assert o.not_in_other == 'foo_bar' + # pylint: enable=no-member # Test using DEFAULT_CONFIG: defaults = dict(constants.DEFAULT_CONFIG) diff --git a/ipatests/test_ipalib/test_frontend.py b/ipatests/test_ipalib/test_frontend.py index 1dd054131..e9f825cf2 100644 --- a/ipatests/test_ipalib/test_frontend.py +++ b/ipatests/test_ipalib/test_frontend.py @@ -365,7 +365,9 @@ class test_Command(ClassChecker): inst.finalize() assert type(inst.output) is NameSpace assert list(inst.output) == ['result'] + # pylint: disable=no-member assert type(inst.output.result) is output.Output + # pylint: enable=no-member def test_iter_output(self): """ diff --git a/pylint_plugins.py b/pylint_plugins.py index d0ed045f7..cc9397427 100644 --- a/pylint_plugins.py +++ b/pylint_plugins.py @@ -406,6 +406,7 @@ AstroidBuilder(MANAGER).string_build(textwrap.dedent( api.env.container_automount = DN() api.env.container_ca = DN() api.env.container_ca_renewal = DN() + api.env.container_subids = DN() api.env.container_caacl = DN() api.env.container_certmap = DN() api.env.container_certmaprules = DN() @@ -470,10 +471,6 @@ AstroidBuilder(MANAGER).string_build(textwrap.dedent( api.env.interactive = True api.env.ipalib = '' # object api.env.kinit_lifetime = None - api.env.lite_pem = '' - api.env.lite_profiler = '' - api.env.lite_host = '' - api.env.lite_port = 0 api.env.log = '' # object api.env.logdir = '' # object api.env.mode = '' @@ -500,6 +497,32 @@ AstroidBuilder(MANAGER).string_build(textwrap.dedent( api.env.version = '' api.env.wait_for_dns = 0 api.env.webui_prod = True + + # defined in ipaclient/install/ipa_epn.py + api.env.smtp_server = "" + api.env.smtp_port = 0 + api.env.smtp_user = None + api.env.smtp_password = None + api.env.smtp_client_cert = None + api.env.smtp_client_key = None + api.env.smtp_client_key_pass = None + api.env.smtp_timeout = 0 + api.env.smtp_security = "" + api.env.smtp_admin = "" + api.env.smtp_delay = None + api.env.mail_from = None + api.env.notify_ttls = "" + api.env.msg_charset = "" + api.env.msg_subtype = "" + api.env.msg_subject = "" + + # defined in contrib/lite-server.py + api.env.lite_pem = '' + api.env.lite_profiler = '' + api.env.lite_host = '' + api.env.lite_port = 0 + api.env.lite_tracemalloc = False + """ ))