Fail on unknown Command options
When unknown keyword arguments are passed to a Command, raise an error instead of ignoring them. Options used when IPA calls its commands internally are listed in a new Command attribute called internal_options, and allowed. Previous patches (0b01751c,c45174d6,c5689e7f) made IPA not use unknown keyword arguments in its own commands and tests, but since that some violations were reintroduced in permission_find and tests. Fix those. Tests included; both a frontend unittest and a XML-RPC test via the ping plugin (which was untested previously). https://fedorahosted.org/freeipa/ticket/2509
This commit is contained in:
1 parent
1484ccc404
commit
1235dfa7bf
10 files changed
+123
-28
No files matched your search
@@ -726,7 +726,7 @@ class test_netgroup(Declarative):
|
||||
|
||||
|
||||
dict(
|
||||
desc='Add duplicatehost %r to netgroup %r' % (host1, netgroup1),
|
||||
desc='Add duplicate host %r to netgroup %r' % (host1, netgroup1),
|
||||
command=(
|
||||
'netgroup_add_member', [netgroup1], dict(host=host1)
|
||||
),
|
||||
@@ -960,8 +960,8 @@ class test_netgroup(Declarative):
|
||||
),
|
||||
|
||||
dict(
|
||||
desc='Search for all netgroups using empty memberuser',
|
||||
command=('netgroup_find', [], dict(memberuser=None)),
|
||||
desc='Search for all netgroups using empty member user',
|
||||
command=('netgroup_find', [], dict(user=None)),
|
||||
expected=dict(
|
||||
count=2,
|
||||
truncated=False,
|
||||
|
||||
Reference in new issue
Block a user