From 195e50b93b63e4f30ce83dbcfef278727d48aea2 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Sun, 20 Mar 2016 20:54:26 +0100 Subject: [PATCH] Pylint: use list comprehension instead of iteration Iteration over indexes without calling enumeration fuction is not pythonic and should not be used. In this case iteration can be replaced by list comprehension. Fixing this allows to enable pylint consider-using-enumerate check. Reviewed-By: Petr Spacek Reviewed-By: Lukas Slebodnik --- ipaserver/dcerpc.py | 5 +---- pylintrc | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/ipaserver/dcerpc.py b/ipaserver/dcerpc.py index 6b62b5fea..a93e8ddb2 100644 --- a/ipaserver/dcerpc.py +++ b/ipaserver/dcerpc.py @@ -784,11 +784,8 @@ class DomainValidator(object): return info def string_to_array(what): - blob = [0] * len(what) + return [ord(v) for v in what] - for i in range(len(what)): - blob[i] = ord(what[i]) - return blob class TrustDomainInstance(object): diff --git a/pylintrc b/pylintrc index e469128f4..d75ca13de 100644 --- a/pylintrc +++ b/pylintrc @@ -72,7 +72,6 @@ disable= not-an-iterable, singleton-comparison, misplaced-comparison-constant, - consider-using-enumerate, unneeded-not, not-a-mapping, singleton-comparison