From 2b739701e3e0d92cacc20ef35f759d74d76ed7c5 Mon Sep 17 00:00:00 2001 From: Serhii Tsymbaliuk Date: Thu, 6 Sep 2018 12:06:21 +0200 Subject: [PATCH] Add SAN extension for CSR generation in test_cert (Web UI tests) Reviewed-By: Alexander Bokovoy Reviewed-By: Petr Vobornik --- ipatests/test_webui/crypto_utils.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/ipatests/test_webui/crypto_utils.py b/ipatests/test_webui/crypto_utils.py index 3be325211..96ffe6b4b 100644 --- a/ipatests/test_webui/crypto_utils.py +++ b/ipatests/test_webui/crypto_utils.py @@ -15,9 +15,13 @@ def generate_csr(hostname): key_size=2048, backend=default_backend() ) + hostname = u'{}'.format(hostname) csr = x509.CertificateSigningRequestBuilder() - csr = csr.subject_name(x509.Name([ - x509.NameAttribute(NameOID.COMMON_NAME, u'{}'.format(hostname)) - ])) + csr = csr.subject_name( + x509.Name([x509.NameAttribute(NameOID.COMMON_NAME, hostname)]) + ).add_extension( + x509.SubjectAlternativeName([x509.DNSName(hostname)]), + critical=False + ) csr = csr.sign(key, hashes.SHA256(), default_backend()) - return csr.public_bytes(serialization.Encoding.PEM) + return csr.public_bytes(serialization.Encoding.PEM).decode()