From 39b17ef2abd885ab87c1a39d3036f762b6b084c8 Mon Sep 17 00:00:00 2001 From: Petr Spacek Date: Wed, 2 Nov 2016 19:55:52 +0100 Subject: [PATCH] Build: fix distribution of daemons/ipa-slapi-plugins/ipa-winsync files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All the headers are now listed in _SOURCES variable. It seems weird but this is what GNU Automake manual suggests in section 9.2 Header files: Headers used by programs or convenience libraries are not installed. The noinst_HEADERS variable can be used for such headers. However when the header actually belongs to a single convenience library or program, we recommend listing it in the program’s or library’s _SOURCES variable (see Program Sources) instead of in noinst_HEADERS. This is clearer for the Makefile.am reader. noinst_HEADERS would be the right variable to use in a directory containing only headers and no associated library or program. https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti Reviewed-By: Christian Heimes --- daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am b/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am index aca4b9c26..0b32b84ff 100644 --- a/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am +++ b/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am @@ -21,6 +21,7 @@ plugin_LTLIBRARIES = \ libipa_winsync_la_SOURCES = \ ipa-winsync.c \ + ipa-winsync.h \ ipa-winsync-config.c \ $(NULL)