From 45d776a7bf05f3495dee078c7dd58ed0db13f64a Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Wed, 23 May 2018 16:30:09 -0400 Subject: [PATCH] Don't try to set Kerberos extradata when there is no principal This was causing ns-slapd to segfault in the password plugin. https://pagure.io/freeipa/issue/7561 Signed-off-by: Rob Crittenden Reviewed-By: Rob Crittenden --- daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c index bdb7ee859..7e52a8855 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c @@ -595,7 +595,8 @@ parse_req_done: } else { principal = slapi_ch_smprintf("root/admin@%s", krbcfg->realm); } - ipapwd_set_extradata(pwdata.dn, principal, pwdata.timeNow); + if (principal) + ipapwd_set_extradata(pwdata.dn, principal, pwdata.timeNow); /* Free anything that we allocated above */ free_and_return: