From 4a89da5352314cad4417ee42eac2cd8ad7cdc057 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcritten@redhat.com>
Date: Mon, 24 Aug 2020 16:20:02 -0400
Subject: [PATCH] ipatests: Add option/arg parsing tests for the cli

A typo in passing in options would result in an exception.

For example -verbose was treated as: -v -e rbose

-v and -e are valid options. rbose on its own has no value in the
name-value pair so an exception would result.

https://pagure.io/freeipa/issue/6115

Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
---
 ipatests/test_ipalib/test_plugable.py | 42 +++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/ipatests/test_ipalib/test_plugable.py b/ipatests/test_ipalib/test_plugable.py
index 2d2a83866..0ea0c4155 100644
--- a/ipatests/test_ipalib/test_plugable.py
+++ b/ipatests/test_ipalib/test_plugable.py
@@ -25,6 +25,7 @@ Test the `ipalib.plugable` module.
 # pylint: disable=no-member
 
 import os
+import sys
 import textwrap
 
 from ipalib import plugable, errors, create_api
@@ -301,3 +302,44 @@ class test_API(ClassChecker):
                 os.environ['IPA_CONFDIR'] = ipa_confdir
             else:
                 os.environ.pop('IPA_CONFDIR')
+
+
+class test_cli(ClassChecker):
+    """
+    Test the `ipalib.plugable` global bootstrap.
+    """
+    def test_no_args(self):
+        sys.argv = ['/usr/bin/ipa']
+        api = create_api(mode='unit_test')
+        (_options, argv) = api.bootstrap_with_global_options(
+            context='unit_test')
+        assert len(argv) == 0
+        assert _options.env is None
+        assert _options.conf is None
+        assert _options.debug is None
+        assert _options.delegate is None
+        assert _options.verbose is None
+
+    def test_one_arg(self):
+        sys.argv = ['/usr/bin/ipa', 'user-show']
+        api = create_api(mode='unit_test')
+        (_options, argv) = api.bootstrap_with_global_options(
+            context='unit_test')
+        assert argv == ['user-show']
+        assert _options.verbose is None
+
+    def test_args_valid_option(self):
+        sys.argv = ['/usr/bin/ipa', '-v', 'user-show']
+        api = create_api(mode='unit_test')
+        (_options, argv) = api.bootstrap_with_global_options(
+            context='unit_test')
+        assert argv == ['user-show']
+        assert _options.verbose == 1
+
+    def test_args_invalid_option(self):
+        sys.argv = ['/usr/bin/ipa', '-verbose', 'user-show']
+        api = create_api(mode='unit_test')
+        try:
+            api.bootstrap_with_global_options(context='unit_test')
+        except errors.OptionError as e:
+            assert e.msg == 'Unable to parse option rbose'