From 54765474167f70f6ac09c8a41dea7a242b34ff7e Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Wed, 26 Sep 2018 23:12:55 +0300 Subject: [PATCH] Fix javascript 'errors' found by jslint There are several JavaScript errors, which have come with PRs: 2362, 2371, 2372. JavaScript code have to follow jsl requires. Fixes: https://pagure.io/freeipa/issue/7717 Fixes: https://pagure.io/freeipa/issue/7718 Reviewed-By: Christian Heimes --- install/html/ssbrowser.html | 12 +++--- install/html/unauthorized.html | 9 +++-- install/migration/index.html | 2 +- install/ui/jsl.conf | 4 +- install/ui/src/freeipa/aci.js | 38 +++++++++---------- install/ui/src/freeipa/automember.js | 8 ++-- install/ui/src/freeipa/automount.js | 12 +++--- install/ui/src/freeipa/dns.js | 12 +++--- install/ui/src/freeipa/group.js | 20 +++++----- install/ui/src/freeipa/hbac.js | 28 +++++++------- install/ui/src/freeipa/host.js | 12 +++--- install/ui/src/freeipa/hostgroup.js | 16 ++++---- install/ui/src/freeipa/idrange.js | 4 +- install/ui/src/freeipa/idviews.js | 12 +++--- install/ui/src/freeipa/netgroup.js | 8 ++-- install/ui/src/freeipa/otptoken.js | 6 +-- install/ui/src/freeipa/plugins/ca.js | 4 +- install/ui/src/freeipa/plugins/caacl.js | 18 ++++----- install/ui/src/freeipa/plugins/certmap.js | 4 +- install/ui/src/freeipa/plugins/certprofile.js | 4 +- install/ui/src/freeipa/policy.js | 4 +- install/ui/src/freeipa/radiusproxy.js | 4 +- install/ui/src/freeipa/selinux.js | 12 +++--- install/ui/src/freeipa/service.js | 8 ++-- install/ui/src/freeipa/stageuser.js | 8 ++-- install/ui/src/freeipa/sudo.js | 38 +++++++++---------- install/ui/src/freeipa/topology.js | 10 ++--- install/ui/src/freeipa/trust.js | 6 +-- install/ui/src/freeipa/user.js | 10 ++--- install/ui/src/freeipa/vault.js | 14 +++---- install/ui/src/freeipa/widget.js | 2 +- 31 files changed, 176 insertions(+), 173 deletions(-) diff --git a/install/html/ssbrowser.html b/install/html/ssbrowser.html index 6201d8829..faa7e657b 100644 --- a/install/html/ssbrowser.html +++ b/install/html/ssbrowser.html @@ -26,7 +26,7 @@ }; (function() { var icons = [ - '../ui/favicon.ico', + '../ui/favicon.ico' ]; var styles = [ '../ui/css/patternfly.css', @@ -35,17 +35,17 @@ var scripts = [ '../ui/js/libs/jquery.js', '../ui/js/libs/jquery.ordered-map.js', - '../ui/js/dojo/dojo.js', + '../ui/js/dojo/dojo.js' ]; ipa_loader.scripts(scripts, function() { require([ 'dojo/dom', 'freeipa/core', - 'dojo/domReady!', + 'dojo/domReady!' ], function(dom) { var text = require('freeipa/text'); - msg = "".concat( + var msg = "".concat( text.get('@i18n:ssbrowser-page.header'), text.get('@i18n:ssbrowser-page.firefox-header'), text.get('@i18n:ssbrowser-page.firefox-actions'), @@ -53,8 +53,8 @@ text.get('@i18n:ssbrowser-page.chrome-certificate'), text.get('@i18n:ssbrowser-page.chrome-spnego'), text.get('@i18n:ssbrowser-page.ie-header'), - text.get('@i18n:ssbrowser-page.ie-actions'), - ) + text.get('@i18n:ssbrowser-page.ie-actions') + ); dom.byId('ssbrowser-msg').innerHTML=msg; }); }); diff --git a/install/html/unauthorized.html b/install/html/unauthorized.html index b5c22ae33..630982da8 100644 --- a/install/html/unauthorized.html +++ b/install/html/unauthorized.html @@ -26,7 +26,7 @@ }; (function() { var icons = [ - '../ui/favicon.ico', + '../ui/favicon.ico' ]; var styles = [ '../ui/css/patternfly.css', @@ -35,18 +35,19 @@ var scripts = [ '../ui/js/libs/jquery.js', '../ui/js/libs/jquery.ordered-map.js', - '../ui/js/dojo/dojo.js', + '../ui/js/dojo/dojo.js' ]; ipa_loader.scripts(scripts, function() { require([ 'dojo/dom', 'freeipa/core', - 'dojo/domReady!', + 'dojo/domReady!' ], function(dom) { var text = require('freeipa/text'); - if (msg = text.get('@i18n:unauthorized-page')) { + var msg = text.get('@i18n:unauthorized-page'); + if (msg) { dom.byId('unauthorized-msg').innerHTML=msg; } }); diff --git a/install/migration/index.html b/install/migration/index.html index 7cdd6e38a..fca517cdc 100644 --- a/install/migration/index.html +++ b/install/migration/index.html @@ -10,7 +10,7 @@ - +