From 59cf9017a009bb5eb4f6ef0ed07aa21e60614ab3 Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <abokovoy@redhat.com>
Date: Tue, 3 May 2022 21:49:32 +0300
Subject: [PATCH] web ui: do not provide Remove button in subid page

subid range management does not allow to delete ranges

If subid range was allocated, it cannot be removed because there might
be file objects associated with it on one of IPA clients.

In Web UI a button to remove the range should not be shown.

Remove corresponding test from the Web UI test for subid as the button
to remove the subid range is not present anymore.

Fixes: https://pagure.io/freeipa/issue/9150

Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Reviewed-By: Armando Neto <abiagion@redhat.com>
---
 install/ui/src/freeipa/subid.js   | 18 ++++++++++++++++++
 ipatests/test_webui/test_subid.py | 14 --------------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/install/ui/src/freeipa/subid.js b/install/ui/src/freeipa/subid.js
index 32f75bb78..b73721115 100644
--- a/install/ui/src/freeipa/subid.js
+++ b/install/ui/src/freeipa/subid.js
@@ -16,12 +16,30 @@ define([
 
 var exp = IPA.subid = {};
 
+exp.search_facet_control_buttons_pre_op = function(spec, context) {
+    spec.control_buttons = [
+        {
+            name: 'add',
+            label: '@i18n:buttons.add',
+            icon: 'fa-plus'
+        },
+        {
+            name: 'refresh',
+            label: '@i18n:buttons.refresh',
+            icon: 'fa-refresh'
+        }
+    ];
+
+    return spec;
+};
+
 var make_spec = function() {
 return {
     name: 'subid',
     facets: [
         {
             $type: 'search',
+            $pre_ops: [ exp.search_facet_control_buttons_pre_op ],
             columns: [
                 'ipauniqueid',
                 'ipaowner',
diff --git a/ipatests/test_webui/test_subid.py b/ipatests/test_webui/test_subid.py
index 26decdba0..319c47048 100644
--- a/ipatests/test_webui/test_subid.py
+++ b/ipatests/test_webui/test_subid.py
@@ -125,17 +125,3 @@ class test_subid(UI_driver):
         self.assert_no_error_dialog()
         after_count = self.get_rows()
         assert len(before_count) < len(after_count)
-
-    @screenshot
-    def test_subid_del(self):
-        """
-        Test to remove subordinate id for given user.
-        """
-        self.init_app()
-        self.navigate_to_entity('subid', facet='search')
-        user_uid = self.get_record_pkey("some-user", "ipaowner",
-                                        table_name="ipauniqueid")
-        before_count = self.get_rows()
-        self.delete_record(user_uid, table_name="ipauniqueid")
-        after_count = self.get_rows()
-        assert len(before_count) > len(after_count)