From 85b8d8d5aeda0bedfab55a4a0e6d15ddc865d59f Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Thu, 23 Jan 2014 13:08:04 +0100 Subject: [PATCH] CA-less tests: Use sequential certificate serial numbers When serial numbers were generated with $RANDOM, there could be collisions. Use sequential numbers instead. Reviewed-By: Adam Misnyovszki --- ipatests/test_integration/scripts/caless-create-pki | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ipatests/test_integration/scripts/caless-create-pki b/ipatests/test_integration/scripts/caless-create-pki index a0b6f13c0..f428ebae1 100644 --- a/ipatests/test_integration/scripts/caless-create-pki +++ b/ipatests/test_integration/scripts/caless-create-pki @@ -5,6 +5,8 @@ profile_server=(-t ,, -v 12) crl_path=${crl_path-$(readlink -f $dbdir)} +serial_number=0 + gen_cert() { local profile="$1" nick="$2" subject="$3" ca options pwfile noise csr crt shift 3 @@ -46,7 +48,8 @@ file://$crl_path/$ca.crl n n EOF - certutil -C -d "$dbdir" -f "$pwfile" -m "$RANDOM" -i "$csr" -o "$crt" "${options[@]}" "$@" + serial_number=$(($serial_number+1)) + certutil -C -d "$dbdir" -f "$pwfile" -m "$serial_number" -i "$csr" -o "$crt" "${options[@]}" "$@" certutil -A -d "$dbdir" -n "$nick" -f "$pwfile" -i "$crt" "${options[@]}" rm -f "$pwfile" "$noise" "$csr" "$crt"