From 8657b57a042b02ebe6294ed7a474ed8fe286d3e3 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Sun, 16 Sep 2018 23:14:45 +0300 Subject: [PATCH] Add title to 'Remove' dialog for 'association_table' widget of 'Automember' entity To improve translation quality the title of 'Remove' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7704 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/freeipa/automember.js | 10 ++++++++-- ipaserver/plugins/internal.py | 6 ++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/install/ui/src/freeipa/automember.js b/install/ui/src/freeipa/automember.js index 1a2a8f1bf..5c5144b8b 100644 --- a/install/ui/src/freeipa/automember.js +++ b/install/ui/src/freeipa/automember.js @@ -295,7 +295,10 @@ IPA.automember.rule_details_facet = function(spec) { required: true } ] - } + }, + deleter_dialog: { + title: '@i18n:objects.automember.remove_inc_conditions', + }, } ] }, @@ -325,7 +328,10 @@ IPA.automember.rule_details_facet = function(spec) { required: true } ] - } + }, + deleter_dialog: { + title: '@i18n:objects.automember.remove_exc_conditions', + }, } ] } diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py index db44ec570..ffbb28f16 100644 --- a/ipaserver/plugins/internal.py +++ b/ipaserver/plugins/internal.py @@ -476,6 +476,12 @@ class i18n_messages(Command): "hostgrouprules": _("Host group rules"), "inclusive": _("Inclusive"), "remove": _("Remove auto membership rules"), + "remove_exc_conditions": _( + "Remove exclusive conditions from rule '${primary_key}'" + ), + "remove_inc_conditions": _( + "Remove inclusive conditions from rule '${primary_key}'" + ), "usergrouprule": _("User group rule"), "usergrouprules": _("User group rules"), },