From 910ff25badbea39c5b0381c7fa0d26131e77e1df Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Tue, 11 Jun 2019 16:36:04 +0200 Subject: [PATCH] ipatests: fix TestUserPermissions::test_selinux_user_optimized MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This test requires SELinux and fails if selinux is disabled (because it's calling semanage login -l). The vagrant images currently in use in the nightly tests are configured with selinux disabled. Add skipif marker when selinux is disabled. Fixes: https://pagure.io/freeipa/issue/7974 Reviewed-By: François Cami --- ipatests/test_integration/test_user_permissions.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ipatests/test_integration/test_user_permissions.py b/ipatests/test_integration/test_user_permissions.py index 3c04e6e75..a7e2c91d7 100644 --- a/ipatests/test_integration/test_user_permissions.py +++ b/ipatests/test_integration/test_user_permissions.py @@ -9,6 +9,7 @@ import pytest from ipaplatform.osinfo import osinfo from ipaplatform.paths import paths +from ipaplatform.tasks import tasks as platformtasks from ipatests.test_integration.base import IntegrationTest from ipatests.pytest_ipa.integration import tasks @@ -70,6 +71,9 @@ class TestUserPermissions(IntegrationTest): # call ipa user-del --preserve self.master.run_command(['ipa', 'user-del', '--preserve', testuser]) + @pytest.mark.skipif( + not platformtasks.is_selinux_enabled(), + reason="Test needs SELinux enabled") @pytest.mark.xfail( osinfo.id == 'fedora' and osinfo.version_number <= (28,), reason='sssd ticket 3819', strict=True)