From 93f8840ed8f484c7880534b86aaad3d1f8fb0d2e Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Thu, 14 Jan 2021 11:24:55 -0500 Subject: [PATCH] ipa-kdb: Fix logic to prevent NULL pointer dereference Discovered by coverity Signed-off-by: Rob Crittenden Reviewed-By: Robbie Harwood Reviewed-By: Alexander Bokovoy --- daemons/ipa-kdb/ipa_kdb_kdcpolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c b/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c index 7f03f2f03..4735abc68 100644 --- a/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c +++ b/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c @@ -76,7 +76,7 @@ ipa_kdcpolicy_check_as(krb5_context context, krb5_kdcpolicy_moddata moddata, } ied = (struct ipadb_e_data *)client_actual->e_data; - if (ied == NULL && ied->magic != IPA_E_DATA_MAGIC) { + if (ied == NULL || ied->magic != IPA_E_DATA_MAGIC) { krb5_klog_syslog(LOG_ERR, "IPA kdcpolicy: client e_data fetching failed."); return EINVAL; }