public/freeipa
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipa_pwd: Remove unnecessary conditional

Browse Source 
It is already confirmed that item_data is not NULL so there
is no need to check it again.

Discovered by coverity.

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Robbie Harwood <rharwood@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Rob Crittenden authored and Florence Blanc-Renaud committed 2021-01-15 10:01:28 +01:00
1 parent a129e6f042
commit 99ea326b1c
1 file changed
-3
Download Patch File Download Diff File Expand all files Collapse all files
util/ipa_pwd.c
-3
View File
@@ -312,9 +312,6 @@ static int ipapwd_cmp_password(char *password, char *historyString)
} }
size_t item_len = EVP_DecodeBlock(item_data, (unsigned char *) b64part, b64_len); size_t item_len = EVP_DecodeBlock(item_data, (unsigned char *) b64part, b64_len);
if (!item_data) {
return -1;
}
if (item_len <= SHA_SALT_LENGTH) { if (item_len <= SHA_SALT_LENGTH) {
ret = -1; ret = -1;
goto done; goto done;