From a355646c37f8b36549d79b2f1cbaeb428d2c98d8 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Fri, 5 Jun 2020 12:38:10 +0200 Subject: [PATCH] build: Unify compiler warning flags used Related: https://pagure.io/freeipa/issue/8351 Reviewed-By: Alexander Bokovoy Reviewed-By: Rob Crittenden --- client/Makefile.am | 8 -------- configure.ac | 1 + daemons/Makefile.am | 8 -------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/client/Makefile.am b/client/Makefile.am index 0031c04a5..91fa71235 100644 --- a/client/Makefile.am +++ b/client/Makefile.am @@ -4,14 +4,6 @@ AUTOMAKE_OPTIONS = 1.7 subdir-objects NULL = -AM_CFLAGS = $(NULL) -if HAVE_GCC - AM_CFLAGS += -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith \ - -Wcast-align -Werror-implicit-function-declaration \ - $(NULL) -endif -export AM_CFLAGS - IPA_CONF_FILE=$(sysconfdir)/ipa/default.conf AM_CPPFLAGS = \ diff --git a/configure.ac b/configure.ac index 9bfd93fdd..160dd586a 100644 --- a/configure.ac +++ b/configure.ac @@ -469,6 +469,7 @@ if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes \ -Wnested-externs -Wpointer-arith \ -Wcast-align -Wsign-compare \ + -Wshadow -Wstrict-prototypes \ $CFLAGS" for option in -Wno-strict-aliasing -Wno-sign-compare; do diff --git a/daemons/Makefile.am b/daemons/Makefile.am index 296791785..f8f3ed5b2 100644 --- a/daemons/Makefile.am +++ b/daemons/Makefile.am @@ -4,14 +4,6 @@ AUTOMAKE_OPTIONS = 1.7 subdir-objects NULL = -AM_CFLAGS = $(NULL) -if HAVE_GCC - AM_CFLAGS += -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith \ - -Wcast-align -Werror-implicit-function-declaration \ - $(NULL) -endif -export AM_CFLAGS - nodist_noinst_HEADERS = ipa-version.h noinst_HEADERS = ipa-version.h.in