From a49cf51ee254440610d26e30dfb306b3108bb1cd Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 3 Nov 2011 13:45:06 -0400 Subject: [PATCH] Fix CID 11022: Resource leak https://fedorahosted.org/freeipa/ticket/2037 --- daemons/ipa-kdb/ipa_kdb_principals.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/daemons/ipa-kdb/ipa_kdb_principals.c b/daemons/ipa-kdb/ipa_kdb_principals.c index fdd834f35..117eea869 100644 --- a/daemons/ipa-kdb/ipa_kdb_principals.c +++ b/daemons/ipa-kdb/ipa_kdb_principals.c @@ -1571,6 +1571,7 @@ static krb5_error_code ipadb_entry_to_mods(krb5_context kcontext, char **new_history; int nh_len; int ret; + int i; ied = (struct ipadb_e_data *)entry->e_data; if (ied->magic != IPA_E_DATA_MAGIC) { @@ -1619,6 +1620,12 @@ static krb5_error_code ipadb_entry_to_mods(krb5_context kcontext, kerr = ipadb_get_ldap_mod_str_list(imods, "passwordHistory", new_history, nh_len, mod_op); + + for (i = 0; i < nh_len; i++) { + free(new_history[i]); + } + free(new_history); + if (kerr) { goto done; }