From bf49664ddd93c5191582e2faf847cae807e1b0d8 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Fri, 21 Sep 2018 14:39:35 +0300 Subject: [PATCH] Drop concatenated title of 'add' dialog for 'attribute_table' widget To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/freeipa/widget.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js index b3e342b83..e4b6f12ad 100644 --- a/install/ui/src/freeipa/widget.js +++ b/install/ui/src/freeipa/widget.js @@ -4418,10 +4418,9 @@ IPA.attribute_table_widget = function(spec) { $.extend(dialog_spec, that.adder_dialog_spec); } - var label = that.entity.metadata.label_singular; var pkey = that.facet.get_pkey(); - dialog_spec.title = text.get(dialog_spec.title || '@i18n:dialogs.add_title'); - dialog_spec.title = dialog_spec.title.replace('${entity}', label); + dialog_spec.title = text.get(dialog_spec.title || + '@i18n:dialogs.add_title_default'); dialog_spec.title = dialog_spec.title.replace('${pkey}', pkey);