From c31bf3d430763ef5b0ef28510995af48dccde287 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= Date: Wed, 16 Sep 2020 17:07:21 +0200 Subject: [PATCH] ipatests: check that pkispawn log is not empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since commits: https://github.com/dogtagpki/pki/commit/0102d836f4eac0fcea0adddb4c98d5ea05e4e8f6 https://github.com/dogtagpki/pki/commit/de217557a642d799b1c4c390efa55493707c738e pkispawn will not honor the pki_log_level configuration item. All 10.9 Dogtag versions have these commits. This affects FreeIPA in that it makes debugging Dogtag installation issues next to impossible. Adding --debug to the pkispawn CLI is required to revert to the previous behavior. Therefore check that the log is not empty and contains DEBUG+INFO lines. Fixes: https://pagure.io/freeipa/issue/8503 Signed-off-by: François Cami Reviewed-By: Thomas Woerner Reviewed-By: Christian Heimes Reviewed-By: Rob Crittenden --- ipatests/test_integration/test_commands.py | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/ipatests/test_integration/test_commands.py b/ipatests/test_integration/test_commands.py index e3c9f54a9..e005414fc 100644 --- a/ipatests/test_integration/test_commands.py +++ b/ipatests/test_integration/test_commands.py @@ -1295,3 +1295,26 @@ class TestIPACommand(IntegrationTest): ) assert result.returncode == 1 assert msg in result.stderr_text + + def test_pkispawn_log_is_present(self): + """ + This testcase checks if pkispawn logged properly. + It is a candidate from being moved out of test_commands. + """ + result = self.master.run_command( + ["ls", "/var/log/pki/"] + ) + pkispawnlogfile = None + for file in result.stdout_text.splitlines(): + if file.startswith("pki-ca-spawn"): + pkispawnlogfile = file + break + assert pkispawnlogfile is not None + pkispawnlogfile = os.path.sep.join(("/var/log/pki", pkispawnlogfile)) + pkispawnlog = self.master.get_file_contents( + pkispawnlogfile, encoding='utf-8' + ) + # Totally arbitrary. pkispawn debug logs tend to be > 10KiB. + assert len(pkispawnlog) > 1024 + assert "DEBUG" in pkispawnlog + assert "INFO" in pkispawnlog