From c3f23da49dc63865d9d7b4f13bb0bded9efa9534 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Wed, 22 Aug 2018 22:36:24 +0300 Subject: [PATCH] Fix "get_key_index" to fit caller's expectations The clients of "get_key_index" expect index of key in matching case otherwise -1. But instead of this function returns the "undefined" value. Fixes: https://pagure.io/freeipa/issue/7678 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/libs/jquery.ordered-map.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/install/ui/src/libs/jquery.ordered-map.js b/install/ui/src/libs/jquery.ordered-map.js index b25dc3379..4d3be294b 100644 --- a/install/ui/src/libs/jquery.ordered-map.js +++ b/install/ui/src/libs/jquery.ordered-map.js @@ -125,7 +125,11 @@ jQuery.ordered_map = jQuery.fn.ordered_map = function(map) { }; that.get_key_index = function(key) { - return that._key_indicies[key]; + var index = that._key_indicies[key]; + if (index !== undefined) { + return index; + } + return -1; }; that.get_key_by_index = function(index) {