From c4729e1155d858be2eb34dc53bd8769711ccd4bf Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Sun, 16 Sep 2018 23:14:45 +0300 Subject: [PATCH] Add a title to 'remove' dialog for details of 'Services' entity To improve translation quality the title of 'Remove' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7702 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/freeipa/service.js | 8 +++++++- ipaserver/plugins/internal.py | 6 ++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/install/ui/src/freeipa/service.js b/install/ui/src/freeipa/service.js index 9db799ae5..387521096 100644 --- a/install/ui/src/freeipa/service.js +++ b/install/ui/src/freeipa/service.js @@ -366,11 +366,17 @@ return { IPA.service.certificate_policy ] }, + { + $type: 'association', + name: 'memberof_role', + remove_title: '@i18n:objects.service.remove_from_roles', + }, { $type: 'association', name: 'managedby_host', add_method: 'add_host', - remove_method: 'remove_host' + remove_method: 'remove_host', + remove_title: '@i18n:objects.service.remove_hosts_managing', } ], standard_association_facets: true, diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py index 13d47e143..03a478d66 100644 --- a/ipaserver/plugins/internal.py +++ b/ipaserver/plugins/internal.py @@ -864,6 +864,12 @@ class i18n_messages(Command): "missing": _("Kerberos Key Not Present"), "provisioning": _("Provisioning"), "remove": _("Remove services"), + "remove_from_roles": _( + "Remove service '${primary_key}' from roles" + ), + "remove_hosts_managing": _( + "Remove hosts managing service '${primary_key}'" + ), "service": _("Service"), "status": _("Status"), "unprovision": _("Unprovision"),