From d23376f54f02acc05bae43d318a83ffafa09d712 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Thu, 13 Sep 2018 21:53:29 +0300 Subject: [PATCH] Add title to remove dialog of 'ID Views' entity To improve translation quality the title of Remove dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7699 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/freeipa/idviews.js | 15 ++++++++++++--- ipaserver/plugins/internal.py | 3 +++ 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/install/ui/src/freeipa/idviews.js b/install/ui/src/freeipa/idviews.js index afd2dadd2..66cdf4950 100644 --- a/install/ui/src/freeipa/idviews.js +++ b/install/ui/src/freeipa/idviews.js @@ -215,7 +215,10 @@ return { name: 'description' } ] - } + }, + deleter_dialog: { + title: '@i18n:objects.idview.remove', + }, };}; var make_idoverrideuser_spec = function() { @@ -328,7 +331,10 @@ return { name: 'description' } ] - } + }, + deleter_dialog: { + title: '@i18n:objects.idview.remove_users', + }, };}; var make_idoverridegroup_spec = function() { @@ -408,7 +414,10 @@ return { name: 'description' } ] - } + }, + deleter_dialog: { + title: '@i18n:objects.idview.remove_groups', + }, };}; diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py index 5becae965..1c9459e19 100644 --- a/ipaserver/plugins/internal.py +++ b/ipaserver/plugins/internal.py @@ -693,6 +693,9 @@ class i18n_messages(Command): "apply_hosts_title": _("Apply ID view ${primary_key} on ${entity}"), "ipaassignedidview": _("Assigned ID View"), "overrides_tab": _("${primary_key} overrides:"), + "remove": _("Remove ID views"), + "remove_users": _("Remove user ID overrides"), + "remove_groups": _("Remove group ID overrides"), "unapply_hostgroups": _("Un-apply from host groups"), "unapply_hostgroups_all_title": _("Un-apply ID Views from hosts of hostgroups"), "unapply_hostgroups_title": _("Un-apply ID View ${primary_key} from hosts of ${entity}"),