Fixes minor issues
Fixes issues discovered by Coverity plugins/baseldap.py: possible undefined value in return certmonger.py: possible dereference of None value i18n.py: fixed always True bug (+ cosmetic change) https://fedorahosted.org/freeipa/ticket/5661 Reviewed-By: Jan Cholasta <jcholast@redhat.com> Reviewed-By: Martin Basti <mbasti@redhat.com>
This commit is contained in:
1 parent
9757384c7c
commit
d7efd8a33a
3 files changed
+13
-7
No files matched your search
+10
-4
@@ -318,8 +318,11 @@ def request_cert(nssdb, nickname, subject, principal, passwd_fname=None):
|
||||
if result[0]:
|
||||
request = _cm_dbus_object(cm.bus, cm, result[1], DBUS_CM_REQUEST_IF,
|
||||
DBUS_CM_IF, True)
|
||||
except TypeError:
|
||||
root_logger.error('Failed to get create new request.')
|
||||
else:
|
||||
raise RuntimeError('add_request() returned False')
|
||||
except Exception as e:
|
||||
root_logger.error('Failed to create a new request: {error}'
|
||||
.format(error=e))
|
||||
raise
|
||||
return request.obj_if.get_nickname()
|
||||
|
||||
@@ -356,8 +359,11 @@ def start_tracking(nickname, secdir, password_file=None, command=None):
|
||||
if result[0]:
|
||||
request = _cm_dbus_object(cm.bus, cm, result[1], DBUS_CM_REQUEST_IF,
|
||||
DBUS_CM_IF, True)
|
||||
except TypeError as e:
|
||||
root_logger.error('Failed to add new request.')
|
||||
else:
|
||||
raise RuntimeError('add_request() returned False')
|
||||
except Exception as e:
|
||||
root_logger.error('Failed to add new request: {error}'
|
||||
.format(error=e))
|
||||
raise
|
||||
return request.prop_if.Get(DBUS_CM_REQUEST_IF, 'nickname')
|
||||
|
||||
|
||||
Reference in new issue
Block a user