From d91690d5df9fdbf7bc2e13cd1ee673ab385a05c5 Mon Sep 17 00:00:00 2001 From: Sudhir Menon Date: Tue, 15 Dec 2020 17:19:58 +0530 Subject: [PATCH] ipatests: ipahealthcheck remove test skipped in pytest run TestIpaHealthCLI::test_input_file test was skipped due to bz1866558. Removed the below statement so that the test can now run as the bug is fixed. @pytest.mark.xfail(reason='BZ 1866558', strict=False) Also changed the assert statement to search text in stdout_text rather than sdterr_text Reviewed-By: Florence Blanc-Renaud Reviewed-By: Rob Crittenden --- ipatests/test_integration/test_ipahealthcheck.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py index f6cc1e4e7..bb198113e 100644 --- a/ipatests/test_integration/test_ipahealthcheck.py +++ b/ipatests/test_integration/test_ipahealthcheck.py @@ -2049,7 +2049,6 @@ class TestIpaHealthCLI(IntegrationTest): assert result.returncode == 2 assert 'invalid choice' in result.stderr_text - @pytest.mark.xfail(reason='BZ 1866558', strict=False) def test_input_file(self): """ Verify the --input-file option @@ -2073,13 +2072,13 @@ class TestIpaHealthCLI(IntegrationTest): cmd = self.base_cmd + ["--input-file", "/tmp/enoent"] result = self.master.run_command(cmd, raiseonerr=False) assert result.returncode == 1 - assert 'No such file or directory' in result.stderr_text + assert 'No such file or directory' in result.stdout_text # Invalid input file cmd = ["ipa-healthcheck", "--input-file", paths.IPA_CA_CRT] result = self.master.run_command(cmd, raiseonerr=False) assert result.returncode == 1 - assert 'Expecting value' in result.stderr_text + assert 'Expecting value' in result.stdout_text def test_output_type(self): """