From e280a2f06ae1e7e78bc86122fbb6d6ceded9e34c Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Mon, 17 Feb 2020 16:24:56 +0300 Subject: [PATCH] pylint: Run Pylint over Azure Python scripts > Pylint is a tool that checks for errors in Python code, tries to enforce a > coding standard and looks for code smells. It can also look for certain type > errors, it can recommend suggestions about how particular blocks can be > refactored and can offer you details about the code's complexity. Fixes: https://pagure.io/freeipa/issue/8202 Signed-off-by: Stanislav Levin Reviewed-By: Alexander Bokovoy --- Makefile.am | 5 ++++- freeipa.spec.in | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 15b261b05..e0efbe7a8 100644 --- a/Makefile.am +++ b/Makefile.am @@ -23,6 +23,8 @@ PYTHON_SCRIPT_SUBDIRS = \ $(top_builddir)/install/tools \ $(NULL) +AZURE_PYTHON_SCRIPT_SUBDIR = $(top_builddir)/ipatests/azure + IPA_PLACEHOLDERS = freeipa ipa ipaserver ipatests SUBDIRS = asn1 util client contrib po pypi $(PYTHON_SUBDIRS) $(SERVER_SUBDIRS) @@ -324,7 +326,8 @@ pylint: $(GENERATED_PYTHON_FILES) ipasetup.py python_scripts -name '*~' -o \ -name '*.py' -print -o \ -type f -exec grep -qsm1 '^#!.*\bpython' '{}' \; -print`; \ - echo "Pylint on $(PYTHON) is running, please wait ..."; \ + FILES=`echo -e "$${FILES}\n$(AZURE_PYTHON_SCRIPT_SUBDIR)"`; \ + echo -e "Pylint on $(PYTHON) is running over files:\n$${FILES}\nPlease wait ...\n"; \ PYTHONPATH=$(top_srcdir) $(PYTHON) -m pylint \ --rcfile=$(top_srcdir)/pylintrc \ --load-plugins pylint_plugins \ diff --git a/freeipa.spec.in b/freeipa.spec.in index 5c4fd8a76..ccf648ec4 100755 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -237,6 +237,7 @@ BuildRequires: python3-custodia >= 0.3.1 BuildRequires: python3-dateutil BuildRequires: python3-dbus BuildRequires: python3-dns >= 1.15 +BuildRequires: python3-docker BuildRequires: python3-gssapi >= 1.2.0 BuildRequires: python3-jinja2 BuildRequires: python3-jwcrypto >= 0.4.2