From e89493e26033a800f62a5dceb98ac3dcdcd8c17b Mon Sep 17 00:00:00 2001
From: Stanislav Levin <slev@altlinux.org>
Date: Fri, 21 Sep 2018 11:45:28 +0300
Subject: [PATCH] Add title to 'add' dialog for 'Topology' entity

To improve translation quality the title of 'Add' dialog should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7707
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
---
 install/ui/src/freeipa/topology.js | 6 ++----
 ipaserver/plugins/internal.py      | 2 ++
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/install/ui/src/freeipa/topology.js b/install/ui/src/freeipa/topology.js
index 4c4b381e7..1903f6ace 100644
--- a/install/ui/src/freeipa/topology.js
+++ b/install/ui/src/freeipa/topology.js
@@ -457,6 +457,7 @@ return {
         }
     ],
     adder_dialog: {
+        title: '@i18n:objects.topologylocation.add',
         fields: [
             {
                 $type: 'text',
@@ -1015,10 +1016,7 @@ topology.create_add_dialog = function(spec) {
 
     spec.entity = spec.entity || 'topologysegment';
 
-    var entity = reg.entity.get('topologysegment');
-    var title = text.get('@i18n:dialogs.add_title');
-    var label = entity.metadata.label_singular;
-    spec.title = title.replace('${entity}', label);
+    spec.title = text.get('@i18n:objects.topologysegment.add');
 
     spec.fields = spec.fields || [
         {
diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py
index f50237cd1..c1ca95da5 100644
--- a/ipaserver/plugins/internal.py
+++ b/ipaserver/plugins/internal.py
@@ -1206,12 +1206,14 @@ class i18n_messages(Command):
                 "insufficient_domain_level" : _("Managed topology requires minimal domain level ${domainlevel}"),
             },
             "topologylocation": {
+                "add": _("Add IPA location"),
                 "remove": _("Remove IPA locations"),
                 "remove_servers": _(
                     "Remove IPA servers from IPA location '${primary_key}'"
                 ),
             },
             "topologysegment": {
+                "add": _("Add topology segment"),
                 "remove": _("Remove topology segments"),
             },
             "trust": {