From f18ce013556c5bafe7e9c35e361deb149eef37a4 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 10 Jul 2017 14:54:10 +0200 Subject: [PATCH] IPAOptionParser: fix dict comprehension The statement can be simplified and be more resources friendly Reviewed-By: Tomas Krizek --- ipapython/config.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ipapython/config.py b/ipapython/config.py index 19abfc51e..6e53472e0 100644 --- a/ipapython/config.py +++ b/ipapython/config.py @@ -114,7 +114,10 @@ class IPAOptionParser(OptionParser): Returns all options except those with sensitive=True in the same fashion as parse_args would """ - all_opts_dict = dict([ (o.dest, o) for o in self._get_all_options() if hasattr(o, 'sensitive') ]) + all_opts_dict = { + o.dest: o for o in self._get_all_options() + if hasattr(o, 'sensitive') + } safe_opts_dict = {} for option, value in opts.__dict__.items():