From fbfd64fc2bb00be4b5fad8b1b0b8defb5f69da11 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Sat, 23 Apr 2022 11:01:15 +0200 Subject: [PATCH] ipatests: fix wrong condition in xfail_context for auto private grp The tests TestNonPosixAutoPrivateGroup::test_idoverride_with_auto_private_group and TestPosixAutoPrivateGroup::test_gidnumber_not_corresponding_existing_group are expected to fail until SSSD fixes issues 5988 and 5989. They currently define an xfail_context with a condition based on sssd version but that condition is wrong (as of today, no version of sssd provides the fix). Remove the wrong condition so that the test is always expected to fail. Fixes: https://pagure.io/freeipa/issue/9141 Reviewed-By: Anuja More --- ipatests/test_integration/test_trust.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ipatests/test_integration/test_trust.py b/ipatests/test_integration/test_trust.py index 2f1b25ed7..21c814ff1 100644 --- a/ipatests/test_integration/test_trust.py +++ b/ipatests/test_integration/test_trust.py @@ -1111,9 +1111,8 @@ class TestNonPosixAutoPrivateGroup(BaseTestTrust): assert (uid == self.uid_override and gid == self.gid_override) test_group = self.clients[0].run_command( ["id", nonposixuser]).stdout_text - version = tasks.get_sssd_version(self.clients[0]) - with xfail_context(version <= tasks.parse_version('2.6.3') - and type == "hybrid", + # version = tasks.get_sssd_version(self.clients[0]) + with xfail_context(type == "hybrid", 'https://github.com/SSSD/sssd/issues/5989'): assert "domain users@{0}".format(self.ad_domain) in test_group @@ -1169,8 +1168,8 @@ class TestPosixAutoPrivateGroup(BaseTestTrust): raiseonerr=False) tasks.assert_error(result, "no such user") else: - sssd_version = tasks.get_sssd_version(self.clients[0]) - with xfail_context(sssd_version <= tasks.parse_version('2.6.3'), + # sssd_version = tasks.get_sssd_version(self.clients[0]) + with xfail_context(True, 'https://github.com/SSSD/sssd/issues/5988'): (uid, gid) = self.get_user_id(self.clients[0], posixuser) assert uid == gid