public/freeipa
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,028 Commits 9 Branches 0 Tags
7ef4e9eb810063243fcc575434d856c854b14eee
Commit Graph
946 Commits
Author SHA1 Message Date
Martin Babinsky 2725e440bf Extend keytab retrieval test suite to cover new options 
All new retrieval methods are covered including testing for excluded option
combinations.

https://fedorahosted.org/freeipa/ticket/6409

Reviewed-By: Simo Sorce <ssorce@redhat.com>
 2016-11-08 17:02:44 +01:00
Martin Babinsky 8480d0e333 Modernize ipa-getkeytab test suite 
The test suite is now leveraging host/service tracker objects as test case
fixture, removing much of ad-hoc setup/teardown.

https://fedorahosted.org/freeipa/ticket/6409

Reviewed-By: Simo Sorce <ssorce@redhat.com>
 2016-11-08 17:02:44 +01:00
Lenka Doudova e3b7d235d5 Tests: Fix integration sudo test 
Tests with sudorules using only RunAsGroups attributes with empty RunAsUsers
attribute fail due to different expected value than is really returned. This is
caused by improper behaviour of sudo in versions before 1.8.18 (see [1]), to
which the tests were originally fitted. Changing the expected value to proper
one.

[1] - https://www.sudo.ws/pipermail/sudo-workers/2016-November/001025.html

https://fedorahosted.org/freeipa/ticket/6378

Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
 2016-11-07 12:39:06 +01:00
Tomas Krizek 5b81dbfda1 ipaldap: merge IPAdmin to LDAPClient 
* move IPAdmin methods to LDAPClient
* add extra arguments (cacert, sasl_nocanon) to LDAPClient.__init__()
* add host, port, _protocol to LDAPClient (parsed from ldap_uri)
* create get_ldap_uri() method to create ldap_uri from former
    IPAdmin.__init__() arguments
* replace IPAdmin with LDAPClient + get_ldap_uri()
* remove ununsed function argument hostname from
    enable_replication_version_checking()

https://fedorahosted.org/freeipa/ticket/6461

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-11-07 11:34:03 +01:00
Tomas Krizek de58a5c605 ipaldap: merge simple_bind into LDAPClient 
* Use LDAPClient.simple_bind instead of extra call to IPAdmin.do_simple_bind
* Rename binddn to bind_dn
* Rename bindpw to bind_password
* Explicitly specify bind_dn in all calls

https://fedorahosted.org/freeipa/ticket/6461

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-11-07 11:34:03 +01:00
Lenka Doudova 42d1a06bd1 Tests: Verify that cert commands show CA without --all 
Verify that command cert-find, cert-show and cert-request show CA even without
--all.

https://fedorahosted.org/freeipa/ticket/6410

Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
 2016-10-26 16:53:27 +02:00
Martin Basti 9408085c58 CI: Disable KRA install tests on DL0 
When master is without KRA installed, on domain level0 we cannot install
KRA replicas, thus this tests must be skipped on DL0

https://fedorahosted.org/freeipa/ticket/6088

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-26 15:06:36 +02:00
Martin Basti 11d7b774c4 CI: use --setup-kra with replica installation 
Currently tests were not testing one-step installation of KRA together
with replica. Adding --setup-kra to replica installation instead of
calling ipa-kra-install after.

https://fedorahosted.org/freeipa/ticket/6088

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-26 15:06:36 +02:00
Martin Basti 84ca1fc220 CI: extend replication layouts tests with KRA 
KRA should be tested with warious replication topologies as well, mainly
in domain level 0

https://fedorahosted.org/freeipa/ticket/6088

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-26 15:06:36 +02:00
Christian Heimes 91920e7cb4 Add __name__ == __main__ guards to setup.pys 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
 2016-10-25 18:11:31 +02:00
Ganna Kaihorodova 9b0b970733 Unaccessible variable self.attrs in Tracker 
In tracker, 'self.attrs' variable is created and filled in track_create method.
Some objects are not created but still require access to this variable.
Created 'self.attrs' variable in init

https://fedorahosted.org/freeipa/ticket/6125

Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-10-25 14:09:14 +02:00
Jan Cholasta 0d370a959b pylint: enable the import-error check 
Check for import errors with pylint to make sure new python package
dependencies are not overlooked.

https://fedorahosted.org/freeipa/ticket/6418

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-24 14:11:08 +02:00
Petr Spacek 0d37619db4 Build: move translations from install/po/ to top-level po/ 
Translations are need for client as well. This move is done to remove
dependency between client and install subdirectories.

https://fedorahosted.org/freeipa/ticket/6418

Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
 2016-10-24 13:30:12 +02:00
Petr Spacek 5e028b59bc Build: merge ipatests/man/configure.ac to top-level configure.ac 
At the same time, I removed unnecessary checks for mkdir etc. and added
missing check for gzip.

https://fedorahosted.org/freeipa/ticket/6418

Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
 2016-10-24 13:30:12 +02:00
Christian Heimes 4cd83fb51c Port all setup.py to setuptools 
All setup.py files are now using setuptools through a common file
ipasetup.py. The file is auto-generated and contain all common
settings.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-20 18:43:37 +02:00
Oleg Fayans 5710ecddca Reverted the essertion for replica uninstall returncode 
As the issue with ipa installer always returning 0 returncode was addressed,
the test needs to be made aware of this change.

https://fedorahosted.org/freeipa/ticket/6401

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-10-18 17:30:37 +02:00
Martin Basti 91b51e702f CI: workaround: wait for dogtag before replica-prepare 
In domain level 0 ipa-replica-prepare fails because dogtag is not ready
so soon after final restart during installation (tests are too fast).
Wait 30 seconds before ipa-replica-prepare is executed, to make sure
that dogtag is ready. Remove this workaround when ticket is fixed.

https://fedorahosted.org/freeipa/ticket/6274

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-10-13 17:40:11 +02:00
Oleg Fayans 8b0faa25d1 Test: disabled wrong client domain tests for domlevel 0 
These tests are only relevant for domain level 1

https://fedorahosted.org/freeipa/ticket/6382

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-12 10:53:41 +02:00
Lenka Doudova 8f04d1a793 Tests: Certificate revocation 
Providing tests for certificate revocation to replace deleted tests from
test_cert_find.

https://fedorahosted.org/freeipa/ticket/6349

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-12 10:45:16 +02:00
Lenka Doudova c9c92e3a7f Tests: Remove invalid certplugin tests 
A bunch of certplugin tests were testing number of revoked certificates with
various revocation reasons. Since existence of revoked certificates often
depends on other parts of IdM than IPA, it is not really valid to check their
presence unless creation of revoked certificate is intentionally tested.

https://fedorahosted.org/freeipa/ticket/6349

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-12 10:45:16 +02:00
Martin Babinsky 29829cc55a remove trailing newlines form python modules 
pylint-1.6.4-1.fc26.noarch reports these, hence they should be fixed in order
to build FreeIPA with this version

https://fedorahosted.org/freeipa/ticket/6391

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-12 10:38:52 +02:00
Petr Spacek 8683cbf124 Tests: print what was expected from callables in xmlrpc_tests 
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-11 16:52:37 +02:00
Martin Basti 49b29591aa Pylint: remove unused variables in tests 
Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-10-11 16:50:32 +02:00
Petr Spacek f363dfbeed DNS: Support URI resource record type 
https://fedorahosted.org/freeipa/ticket/6344

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-10-11 16:48:47 +02:00
Lenka Doudova 74e52e8686 Tests: Remove silent deleting and creating entries by tracker 
https://fedorahosted.org/freeipa/ticket/6123

Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-10-06 19:16:37 +02:00
Milan Kubík 10b4b155b6 ipatests: Implement tests with CSRs requesting SAN 
The patch implements several test cases testing the enforcement
of CA ACLs on certificate requests with subject alternative names.

https://fedorahosted.org/freeipa/ticket/6366

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-10-04 18:03:03 +02:00
Milan Kubík 7eb78aa8db ipatests: Fix name property on a service tracker 
https://fedorahosted.org/freeipa/ticket/6366

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-10-04 18:03:03 +02:00
Milan Kubík 4f8e212c42 ipatests: provide context manager for keytab usage in RPC tests 
https://fedorahosted.org/freeipa/ticket/6366

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-10-04 18:03:03 +02:00
Stanislav Laznicka d70d71846d Fix test_util.test_assert_deepequal test 
The test would be failing because recent pretty-print changes
that caused the inner members of a dictionary to be printed
in a different order.

https://fedorahosted.org/freeipa/ticket/6373

Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
 2016-10-04 14:11:00 +02:00
Martin Basti 95aa9369cb Fix: find OSCP certificate test 
Test should check if any OSCP certificate has been returned

https://fedorahosted.org/freeipa/ticket/6359

Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
 2016-09-30 13:13:57 +02:00
Stanislav Laznicka ecd6cb4e45 Pretty-print structures in assert_deepequal 
By default, ipa-run-tests will now pretty-print structures
compared in the assert_deepequal function. This behaviour
can be turned off by the --no-pretty-print option.

https://fedorahosted.org/freeipa/ticket/6212

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-09-30 09:55:58 +02:00
Martin Basti 45e3aee352 Pylint: enable check for unused-variables 
Unused variables may:
* make code less readable
* create dead code
* potentialy hide issues/errors

Enabled check should prevent to leave unused variable in code

Check is locally disabled for modules that fix is not clear or easy or have too many occurences of
unused variables

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
 2016-09-27 13:35:58 +02:00
Martin Basti 9d83be3647 Remove unused variables in tests 
This commit removes or marks unused variables as "expected to be unused"
by using '_' prefix.

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
 2016-09-27 13:35:58 +02:00
Martin Basti 452b08754d test_text: add test ipa.pot file for tests 
Input data should be packaged into freeipa-test module to be able run
test from RPM (outoftree)

https://fedorahosted.org/freeipa/ticket/6333

Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
 2016-09-26 18:48:07 +02:00
Martin Basti 9b68d2a1f8 Pylint: enable global-variable-not-assigned check 
the global keyword should be used only when variable from outside is
assigned inside, otherwise it has no effect and just confuses developers

Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
 2016-09-23 09:23:41 +02:00
Jan Barta f252f50987 pylint: fix bad-classmethod-argument 
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2016-09-22 16:52:57 +02:00
Jan Barta cdecbcd0a1 pylint: fix pointless-statement 
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2016-09-22 16:52:57 +02:00
Jan Barta 275e85d076 pylint: fix unneeded-not 
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2016-09-22 16:52:57 +02:00
Jan Barta 36484e8672 pylint: fix simplifiable-if-statement warnings 
fix inefficient if statements, enable pylint check

Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2016-09-22 16:52:57 +02:00
Martin Basti 929086e099 Test: dont use global variable for iteration in test_cert_plugin 
Iteration over global variable causes unwanted value changes outside
method

https://fedorahosted.org/freeipa/ticket/5755

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-09-22 15:22:56 +02:00
Oleg Fayans 47c808afa3 tests: Fixed code styling in caless tests to make pep8 happy 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 9870c5804a tests: Reverted erroneous asserts in 4 tests 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 7412f0cb20 tests: fixed certinstall method 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans f1f94a7b9f tests: fixed super method invocation 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 8be0906b04 tests: added verbose assert to test_service_disable_doesnt_revoke 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 106f37c26f tests: Standardized replica_preparation in test_no_certs 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans b8968d923c tests: Implemented check for domainlevel before installation verification 
We only need to verify installation of replica under domain level 1, otherwise
replica is not installed but only a gpg file is prepared

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 43994e6697 tests: Fixed Usage of improper certs in ca-less tests 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans 804aae8196 tests: fixed expects of incorrect error messages 
Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00
Oleg Fayans b8cf212e8b tests: Replaced unused setUp method with install 
setUp method does not get executed in recent versions of pytest
Replaced with the install method derived from the parent IntegrationTest class

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-09-22 15:20:42 +02:00