public/freeipa
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,714 Commits 9 Branches 0 Tags
a2a293ed2f40e3688634fc53dccb8d682fd2ab22
Commit Graph
12 Commits
Author SHA1 Message Date
Christian Heimes 85286beb5b Address inconsistent-return-statements 
Pylint warns about inconsistent return statements when some paths of a
function return None implicitly. Make all implicit returns either
explicit or raise a proper exception.

See: https://pagure.io/freeipa/issue/7758
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
 2018-11-13 13:37:58 +01:00
Christian Heimes 204353e4dc Use tasks.install_master() in external_ca tests 
The install_master() function performs additional steps besides just
installing a server. It also sets up log collection and performs
additional tests.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
 2018-10-26 20:10:23 +02:00
Rob Crittenden 552777293d Collect the client and server uninstall logs in tests 
When running the integration tests capture the uninstallation
logs as well as the installation logs.

Reviewed-By: Christian Heimes <cheimes@redhat.com>
 2018-10-26 08:11:03 +02:00
Christian Heimes 15d5e44ee8 Py3: Replace six.moves imports 
Replace six.moves and six.StringIO/BytesIO imports with cannonical
Python 3 packages.

Note: six.moves.input behaves differently than builtin input function.
Therefore I left six.moves.input for now.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
 2018-10-05 12:06:19 +02:00
Christian Heimes 964a9bdcec Py3: Replace six.string_types with str 
In Python 3, six.string_types is just an alias for str.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2018-09-27 16:11:18 +02:00
Christian Heimes 4a58adf79e Sprinkle raw strings across the code base 
tox / pytest is complaining about lots and lots of invalid escape
sequences in our code base. Sprinkle raw strings or backslash escapes
across the code base to fix most occurences of:

  DeprecationWarning: invalid escape sequence

There is still one warning that keeps repeating, though:

  source:264: DeprecationWarning: invalid escape sequence \d

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
 2018-09-27 10:23:03 +02:00
Thomas Woerner 7eb8695e84 Remove DL0 specific code from ipatests/pytest_ipa/integration/tasks.py 
The functions get_replica_filename and replica_prepare are not needed anymore
with the DL0 removal. The DL0 specific code has been removed from the
functions install_replica, install_kra and install_ca.

See: https://pagure.io/freeipa/issue/7689
Signed-off-by: Thomas Woerner <twoerner@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
 2018-09-12 13:11:21 +02:00
Michal Reznik c29581c9a0 add strip_cert_header() to tasks.py 
https://pagure.io/freeipa/issue/7687

Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Tibor Dudlak <tdudlak@redhat.com>
 2018-09-06 13:49:34 +02:00
Michal Reznik 31a92c1677 tests: sssd_ssh fd leaks when user cert converted into SSH key 
https://pagure.io/freeipa/issue/7687

Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Tibor Dudlak <tdudlak@redhat.com>
 2018-09-06 13:49:34 +02:00
Christian Heimes 13000e2f19 Disable DL0 specific tests 
Disable tests that use domain level 0. Fail early to catch additional
tests that depend on DL0.

See: https://pagure.io/freeipa/issue/7669
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Thomas Woerner <twoerner@redhat.com>
 2018-08-13 18:49:05 +02:00
Michal Reznik 0aeccc0852 ipa_tests: test ssh keys login 
Integration test for:

https://pagure.io/SSSD/sssd/issue/3747

IPA ticket: https://pagure.io/freeipa/issue/7664

Reviewed-By: Armando Neto <abiagion@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
 2018-08-10 17:01:45 +02:00
Christian Heimes 6414509343 Rename pytest_plugins to ipatests.pytest_ipa 
pytest 3.7.0 doesn't like ipatests.pytest_plugins package. The string
"pytest_plugins" is used as marker to load plugins. By populare vote and
to avoid future conflicts, we decided to rename the directory to pytest_ipa.

Fixes: https://pagure.io/freeipa/issue/7663
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
 2018-08-02 17:07:43 +02:00