public/freeipa
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,751 Commits 9 Branches 0 Tags
cf713ac28362c40e6414e9bf9701e58e36c07deb
Commit Graph
263 Commits
Author SHA1 Message Date
David Kupka 573819eb07 test: cert: Reflect change in behavior in tests 
Command cert-find with parameter sizelimit set to 0 no longer returns 0
certificates but returns all.

More precise ConversionError is returned when parameter is not
convertible to its type.

https://fedorahosted.org/freeipa/ticket/5381
https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-06-29 14:49:08 +02:00
David Kupka 95191e1612 test: automember: Fix expected exception message 
https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-06-29 10:49:37 +02:00
Stanislav Laznicka 427bbf6c0d The LDAP*ReverseMember shouldn't imply --all is always specified 
The LDAP*ReverseMember methods would always return the whole LDAP
object even though --all is not specified.
Also had to fix some tests as objectClass will not be returned by
default now.

https://fedorahosted.org/freeipa/ticket/5892

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-06-29 10:44:30 +02:00
Petr Spacek bf91c0f938 DNS: Fix tests for realm domains integration with DNS zone add 
We forgot to update tests after change in
22f4045f72.

https://fedorahosted.org/freeipa/ticket/5980

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-06-28 14:19:56 +02:00
Lenka Doudova 22f26cfa8e Tests: Make ID views tests reflect new krbcanonicalname attribute 
https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-06-28 10:50:25 +02:00
Martin Babinsky d0c38d86a1 test-{service,host}-plugin: only expect krbcanonicalname when all=True 
fixes incorrect assertions in tests that create, retrieve, and search for
services

https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
 2016-06-28 09:17:30 +02:00
Martin Babinsky 7b8247a485 keep setting ipakrbprincipal objectclass on new service entries 
this is required for replica promotion to work, since the ACI allowing hosts
to add their own services uses this objectclass as target filter.

This partially reverts changes from commit
705f66f749

https://fedorahosted.org/freeipa/ticket/5996

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-06-27 13:38:07 +02:00
Lenka Doudova eec440b2d5 Tests: Fix for failing location tests 
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-06-23 15:29:06 +02:00
Martin Babinsky 06d945a046 account for added krbcanonicalname attribute during xmlrpc tests 
https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: David Kupka <dkupka@redhat.com>
Reviewed-By: Simo Sorce <ssorce@redhat.com>
 2016-06-23 09:48:06 +02:00
Martin Basti 4155eb7b13 DNS Locations: Rename ipalocationweight to ipaserviceweight 
Service weight explains better meaning of attribute than location
weight, because location itself have no weight only services have.

https://fedorahosted.org/freeipa/ticket/2008

Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-06-17 18:05:03 +02:00
Fraser Tweedale fa149cff86 Remove service and host cert issuer validation 
When adding certifiates to a host or service entry, we currently
check that the issuer matches the issuer DN of the IPA CA.  Now that
sub-CAs have been implemented, this check is no longer valid and
will cause false negatives.  Remove it and update call sites.

Part of: https://fedorahosted.org/freeipa/ticket/4559

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-06-06 08:58:01 +02:00
Martin Basti 42719acdce DNS Locations: extend tests with server-* commands 
https://fedorahosted.org/freeipa/ticket/2008

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-06-03 15:58:21 +02:00
Martin Basti 7c3bcafef0 DNS Locations: API tests 
Tests for location-* commands

https://fedorahosted.org/freeipa/ticket/2008

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
 2016-06-03 15:58:21 +02:00
Jan Cholasta 6e44557b60 ipalib: move server-side plugins to ipaserver 
Move the remaining plugin code from ipalib.plugins to ipaserver.plugins.

Remove the now unused ipalib.plugins package.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-06-03 09:00:34 +02:00
Jan Cholasta 56c66f44a0 rpc: specify connection options in API config 
Specify RPC connection options once in API.bootstrap rather than in each
invocation of rpcclient.connect.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-06-03 09:00:34 +02:00
Martin Basti 05c8808c76 Test: fix failing host_test 
Regression caused by patches related to empty zones

https://fedorahosted.org/freeipa/ticket/5710

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-06-01 08:27:26 +02:00
Martin Basti 5f42b42bd4 Performance: Find commands: do not process members by default 
In all *-find commands, member attributes shouldn't be processed due
high amount fo ldpaserches cause serious performance issues. For this
reason --no-members option is set by default in CLI and API.

To get members in *-find command option --all in CLI is rquired or
'no_members=False' or 'all=True' must be set in API call.

For other commands processing of members stays unchanged. WebUI is not
affected by this change.

https://fedorahosted.org/freeipa/ticket/4995

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-05-31 14:08:54 +02:00
Petr Spacek 70794c7b1d Turn verify_host_resolvable() into a wrapper around ipapython.dnsutil 
The code was duplicate and less generic anyway.
As a side-effect I had to re-wrap dns.exception.DNSException into a
PublicError so it can be displayed to the user.

DNSError is now a super class for other DNS-related errors. Errors from
DNS resolver are re-raised as DNSResolverError.

https://fedorahosted.org/freeipa/ticket/5710

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-30 20:14:32 +02:00
Petr Spacek da71e7e9de DNS: Warn if forwarding policy conflicts with automatic empty zones 
Forwarding policy "first" or "none" may conflicts with some automatic empty
zones. Queries for zones specified by RFC 6303 will ignore
forwarding and recursion and always result in NXDOMAIN answers.

This is not detected and warned about. Global forwarding is equivalent
to forward zone ".".

Example:
Forward zone 1.10.in-addr.arpa with policy "first"
will not forward anything because BIND will automatically prefer
automatic empty zone "10.in-addr.arpa." which is authoritative.

https://fedorahosted.org/freeipa/ticket/5710

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-30 20:14:32 +02:00
Jan Cholasta 60fa6ed444 frontend: merge baseldap.CallbackRegistry into Command 
Also make it possible for subclasses to introduce new callback types.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Jan Cholasta 2f6b333187 frontend: re-raise remote RequirementError using CLI name in CLI 
https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Jan Cholasta e0275abe6f rpc: include structured error information in responses 
Include keyword arguments of exceptions in RPC responses. This is limited
to JSON-RPC, as XML-RPC does not support additional data in error
responses.

Include keyword arguments of messages in RPC responses.

Include keyword arguments of exceptions in batch command result.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Lenka Doudova d71de186cc Test: Maximum username length higher than 255 cannot be set 
https://fedorahosted.org/freeipa/ticket/5774

Reviewed-By: Ganna Kaihorodova <gkaihoro@redhat.com>
 2016-05-24 10:39:14 +02:00
Peter Lacko 144a367d35 Ping module tests. 
Test for ping module rewritten using non-declarative way.
No new functionality has been added.

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-18 17:19:05 +02:00
Petr Viktorin 7d4d819b90 test_cert_plugin: Encode 'certificate' for comparison with 'usercertificate' 
The 'certificate' option is Str, but 'usercertificate' is Bytes.
Decode before comparing one with the other.

Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-10 12:41:15 +02:00
Petr Viktorin 20a6a42567 test_add_remove_cert_cmd: Use bytes for base64.b64encode() 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin bdee890014 radiusproxy plugin tests: Expect bytes, not text, for ipatokenradiussecret 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 14aba1c7c1 range plugin tests: Use bytes with MockLDAP under Python 3 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 095d0cb7af xmlrpc_test: Expect bytes rather than strings for binary attributes 
The attributes krbextradata, krbprincipalkey, and userpassword contain
binary data.

Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 6406c7a593 xmlrpc_test: Rename exception instance before working with it 
Python 3 unsets the exception variable at the end of an "except"
block to prevent reference cycles and speed up garbage collection.

Store the exception under a different name in order to use it later.

Part of the work for https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin f753ad322d test_xmlrpc: Use absolute imports 
In Python 3, a module from the current package can be imported
either with the absolute name or by using an explicit relative import.

Part of the work for https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Martin Basti b87a825d74 fix stageuser tests (removal of has_keytab and has_password from find) 
User tests has been fixed, but stageuser tests was forgotten, this
commit fixes it.

https://fedorahosted.org/freeipa/ticket/5281

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-05 15:20:19 +02:00
Lenka Doudova 847c950408 Test fix: Cleanup for host certificate 
This fix provides means to remove certificates from host that were added during tests, but not removed.

Ticket: https://fedorahosted.org/freeipa/ticket/5839
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-03 17:12:45 +02:00
Martin Basti fe2ce02a6f Performace: don't download password attributes in host/user-find 
For each entry in user/host-find was executed an extra search for password
attributes what has significant impact on performance (for 2000 users
there were 2000 additional searches)

http://www.freeipa.org/page/V4/Performance_Improvements

https://fedorahosted.org/freeipa/ticket/5281

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-04-22 13:28:57 +02:00
Milan Kubík 0472300dff ipatests: Add test case for requesting a certificate with full principal. 
https://fedorahosted.org/freeipa/ticket/5733

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-21 17:06:54 +02:00
Filip Skola 5dfaeca7ce Refactor test_automember_plugin, create AutomemberTracker 
Reviewed-By: Ales 'alich' Marecek <amarecek@redhat.com>
 2016-04-19 10:35:13 +02:00
Martin Babinsky 62bb478e11 specify type of exceeded limit when warning about truncated search results 
API commands inheriting from LDAPSearch should mention which limit was
exceeded in the warning message sent with truncated results.

https://fedorahosted.org/freeipa/ticket/5677

Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-04-13 17:52:22 +02:00
Filip Skola 49c015b2ed Refactor test_hostgroup_plugin 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-24 14:38:22 +01:00
Filip Skola ab3f652dc1 Refactor test_nesting, create HostGroupTracker 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-24 14:36:55 +01:00
Martin Basti ae5bf8291f Fix stageuser-activate - managers test 
https://fedorahosted.org/freeipa/ticket/5481

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-03-23 16:38:26 +01:00
Martin Basti da0318d4d7 Pylint: remove unnecessary-semicolon 
Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
 2016-03-22 10:20:51 +01:00
Martin Babinsky abe3abb466 test_cert_plugin: use only first part of the hostname to construct short name 
The short hostname construction for the negative test case in
test_cert_plugin::test_cert_find suite could not work when domain name was
different as hostname of the test runner, leading to test failure. A more
naive approach works better in this case.

https://fedorahosted.org/freeipa/ticket/5688

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-08 20:22:55 +01:00
Filip Skola de63e16922 Refactor test_group_plugin, use GroupTracker for tests 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-08 16:32:11 +01:00
Martin Basti 72d5499c5a pylint: supress false positive no-member errors 
pylint 1.5 prints many false positive no-member errors which are
supressed by this commit.

https://fedorahosted.org/freeipa/ticket/5615

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-03-02 14:57:36 +01:00
Filip Skola dd38602fa5 Refactor test_sudocmdgroup_plugin 
Reviewed-By: Ales 'alich' Marecek <amarecek@redhat.com>
 2016-03-01 13:50:32 +01:00
Filip Skola 007c360f85 Refactor test_sudocmd_plugin 
Reviewed-By: Ales 'alich' Marecek <amarecek@redhat.com>
 2016-03-01 13:50:32 +01:00
Milan Kubík b32c9d639e ipatests: extend permission plugin test with new expected output 
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-02-25 16:31:15 +01:00
Stanislav Laznicka 9757384c7c Cosmetic changes to the code 
Fixes some Coverity issues

ipadiscovery.py:          added assert should universe break
plugins/dns.py:           removed dead code
dnssec/ldapkeydb.py:      attribute assert in the proper object
test_automount_plugin.py: fixed possible close() on None
xmlrpc_test.py:           Coverity does not like accessing None.__class__

https://fedorahosted.org/freeipa/ticket/5661

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-02-24 09:21:30 +01:00
Milan Kubík 87ee451c7d ipatests: Add missing certificate profile fixture 
https://fedorahosted.org/freeipa/ticket/5630

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-02-11 14:13:56 +01:00
Filip Skola ec75b01f17 Refactor test_attr 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-01-26 19:04:38 +01:00