4 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
3 people	de0644499a	fix: ensure networkmode "host" unless explicitly specified (#1739) ... act defaults network mode to "host", but when `--container-options` are passed on the CLI, it uses the docker CLI options parser, which fills empty values with defaults, in which case network mode is set to "default". Unless the user explicitly sets `--container-options="--network=xxx"`, we should always default to "host", to keep act's behaviour. Co-authored-by: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>	2023-04-18 14:37:59 +00:00
Björn BrauerandMarkus Wolf	3f3b25ae84	feat: add support for building docker actions with private registries (#1557) ... This commit adds a new `LoadDockerAuthConfigs` function, which loads all registry auths that are configured on the host and sends them with the build command to the docker daemon. This is needed in case act builds a docker action and the images referenced in that docker action are located on private registries or otherwise require authentication (e.g. to get a higher rate limit). The code is adapted from how the docker cli works: https://github.com/docker/cli/blob/257ff41304bf121bdf1acdf00a1c7a896ed038d1/cli/command/image/build.go#L323-L332 Co-authored-by: Markus Wolf <mail@markus-wolf.de> Co-authored-by: Markus Wolf <mail@markus-wolf.de>	2023-01-12 21:29:30 +00:00
Björn BrauerandMarkus Wolf	8a9167da82	fix: avoid race condition by not running exec/start twice (#702) ... ContainerExecAttach implicitly runs ContainerExecStart while attaching to stdout/stderr. Ref: https://github.com/moby/moby/blob/e02bc91dcbf6ab70ab39352f3577a4394b0f863a/client/container_exec.go#L40 Calling both can lead to a race condition as observed in #627 Fixes: #627 Co-authored-by: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: Markus Wolf <markus.wolf@new-work.se>	2021-05-25 12:35:52 +00:00
Björn BrauerandMarkus Wolf	60b9606fc6	fix: use github auth token for pulling a repository (#693) ... Co-Authored-By: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: Markus Wolf <markus.wolf@new-work.se>	2021-05-19 13:40:28 +00:00