Close all fds when running another program. This fixes the SELinux AVCs.

Put installation log files into /var/log.

430024
This commit is contained in:
Rob Crittenden committed 2008-03-03 16:14:48 -05:00
1 parent 79557e6bf2
commit b49942fe96
3 files changed
+4 -3

No files matched your search

+1 -1
View File
@@ -54,7 +54,7 @@ def logging_setup(options):
# file.
logging.basicConfig(level=logging.DEBUG,
format='%(asctime)s %(levelname)s %(message)s',
filename='ipaclient-install.log',
filename='/var/log/ipaclient-install.log',
filemode='w')
console = logging.StreamHandler()
+1 -1
View File
@@ -71,7 +71,7 @@ def write_tmp_file(txt):
return fd
def run(args, stdin=None):
p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
if stdin:
stdout,stderr = p.communicate(stdin)
else:
+2 -1
View File
@@ -316,7 +316,8 @@ def main():
signal.signal(signal.SIGTERM, signal_handler)
signal.signal(signal.SIGINT, signal_handler)
standard_logging_setup("ipaserver-install.log", options.debug)
standard_logging_setup("/var/log/ipaserver-install.log", options.debug)
print "\nThe log file for this installation can be found in /var/log/ipaserver-install.log")
if options.uninstall:
return uninstall()