Add title to 'add' dialog for 'Automember' entity

To improve translation quality the title of 'Add' dialog should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7707
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
This commit is contained in:
Stanislav Levin authored and Serhii Tsymbaliuk committed 2018-10-01 10:28:14 +02:00
1 parent bf49664ddd
commit e363fb3ebc
3 files changed
+11 -6

No files matched your search

+3 -3
View File
@@ -105,7 +105,7 @@ return {
],
adder_dialog: {
$factory: IPA.automember.rule_adder_dialog,
title: '@i18n:objects.automember.add_rule',
title: '@i18n:objects.automember.add',
fields: [
{
$type: 'entity_select',
@@ -281,7 +281,7 @@ IPA.automember.rule_details_facet = function(spec) {
add_command: 'add_condition',
remove_command: 'remove_condition',
adder_dialog: {
title: '@i18n:objects.automember.add_condition',
title: '@i18n:objects.automember.add_inc_condition',
fields: [
{
name: 'key',
@@ -314,7 +314,7 @@ IPA.automember.rule_details_facet = function(spec) {
add_command: 'add_condition',
remove_command: 'remove_condition',
adder_dialog: {
title: '@i18n:objects.automember.add_condition',
title: '@i18n:objects.automember.add_exc_condition',
fields: [
{
name: 'key',
+1 -1
View File
@@ -4421,7 +4421,7 @@ IPA.attribute_table_widget = function(spec) {
var pkey = that.facet.get_pkey();
dialog_spec.title = text.get(dialog_spec.title ||
'@i18n:dialogs.add_title_default');
dialog_spec.title = dialog_spec.title.replace('${pkey}', pkey);
dialog_spec.title = dialog_spec.title.replace('${primary_key}', pkey);
var factory = dialog_spec.$factory || IPA.entity_adder_dialog;
+7 -2
View File
@@ -465,8 +465,13 @@ class i18n_messages(Command):
"remove": _("Remove self service permissions"),
},
"automember": {
"add_condition": _("Add Condition into ${pkey}"),
"add_rule": _("Add Rule"),
"add": _("Add rule"),
"add_inc_condition": _(
"Add inclusive condition into '${primary_key}'"
),
"add_exc_condition": _(
"Add exclusive condition into '${primary_key}'"
),
"attribute": _("Attribute"),
"default_host_group": _("Default host group"),
"default_user_group": _("Default user group"),