Compare commits
7 Commits
a7a616463d
...
strongswan
| Author | SHA1 | Date | |
|---|---|---|---|
| f28c40e3b8 | |||
| a183b985eb | |||
| 087a9c32e8 | |||
| 0b4abaf5fe | |||
| f978fcb51f | |||
| d7e57af704 | |||
| 5db540d4e3 |
477
0001-charon-add-optional-source-and-remote-overrides-for-.patch
Normal file
477
0001-charon-add-optional-source-and-remote-overrides-for-.patch
Normal file
@@ -0,0 +1,477 @@
|
||||
From d917774f73954cc6367e73b775ff9ea115d6fd28 Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Zoran=20Peri=C4=8Di=C4=87?= <zpericic@netst.org>
|
||||
Date: Tue, 9 Jul 2024 19:07:57 +0200
|
||||
Subject: [PATCH 1/4] charon: add optional source and remote overrides for
|
||||
initiate
|
||||
|
||||
This introduces support for specifying optional IKE SA specific
|
||||
source and remote address for child sa initiation. This allows
|
||||
to initiate wildcard connection for known address via vici.
|
||||
|
||||
In addition this allows simpler implementation of trap-any patches
|
||||
and is a prerequisite for dmvpn support.
|
||||
---
|
||||
src/libcharon/control/controller.c | 34 ++++++++++++++++--
|
||||
src/libcharon/control/controller.h | 28 +++++++++++++++
|
||||
src/libcharon/plugins/vici/vici_control.c | 41 +++++++++++++++++----
|
||||
src/libcharon/sa/ike_sa_manager.c | 34 +++++++++++++++++-
|
||||
src/libcharon/sa/ike_sa_manager.h | 25 ++++++++++++-
|
||||
src/libcharon/sa/trap_manager.c | 44 +++++++++--------------
|
||||
src/swanctl/commands/initiate.c | 19 +++++++++-
|
||||
7 files changed, 186 insertions(+), 39 deletions(-)
|
||||
|
||||
diff --git a/src/libcharon/control/controller.c b/src/libcharon/control/controller.c
|
||||
index 027f48e937..ac4661a323 100644
|
||||
--- a/src/libcharon/control/controller.c
|
||||
+++ b/src/libcharon/control/controller.c
|
||||
@@ -1,4 +1,6 @@
|
||||
/*
|
||||
+ * Copyright (C) 2023 Zoran Peričić <zpericic@netst.org>
|
||||
+ * Copyright (C) 2014 Timo Teräs <timo.teras@iki.fi>
|
||||
* Copyright (C) 2011-2023 Tobias Brunner
|
||||
* Copyright (C) 2007-2011 Martin Willi
|
||||
*
|
||||
@@ -107,6 +109,16 @@ struct interface_listener_t {
|
||||
*/
|
||||
ike_sa_t *ike_sa;
|
||||
|
||||
+ /**
|
||||
+ * Our host hint.
|
||||
+ */
|
||||
+ host_t *my_host;
|
||||
+
|
||||
+ /**
|
||||
+ * Other host hint.
|
||||
+ */
|
||||
+ host_t *other_host;
|
||||
+
|
||||
/**
|
||||
* unique ID, used for various methods
|
||||
*/
|
||||
@@ -417,10 +429,16 @@ METHOD(job_t, initiate_execute, job_requeue_t,
|
||||
ike_sa_t *ike_sa;
|
||||
interface_listener_t *listener = &job->listener;
|
||||
peer_cfg_t *peer_cfg = listener->peer_cfg;
|
||||
+ host_t *my_host = listener->my_host;
|
||||
+ host_t *other_host = listener->other_host;
|
||||
|
||||
- ike_sa = charon->ike_sa_manager->checkout_by_config(charon->ike_sa_manager,
|
||||
- peer_cfg);
|
||||
+ ike_sa = charon->ike_sa_manager->checkout_by_config2(charon->ike_sa_manager,
|
||||
+ peer_cfg, my_host, other_host);
|
||||
peer_cfg->destroy(peer_cfg);
|
||||
+
|
||||
+ if (my_host) my_host->destroy(my_host);
|
||||
+ if (other_host) other_host->destroy(other_host);
|
||||
+
|
||||
if (!ike_sa)
|
||||
{
|
||||
DESTROY_IF(listener->child_cfg);
|
||||
@@ -501,6 +519,15 @@ METHOD(controller_t, initiate, status_t,
|
||||
private_controller_t *this, peer_cfg_t *peer_cfg, child_cfg_t *child_cfg,
|
||||
controller_cb_t callback, void *param, level_t max_level, u_int timeout,
|
||||
bool limits)
|
||||
+{
|
||||
+ return this->public.initiate2(&this->public, peer_cfg, child_cfg, NULL, NULL, callback, param, max_level, timeout, limits);
|
||||
+}
|
||||
+
|
||||
+METHOD(controller_t, initiate2, status_t,
|
||||
+ private_controller_t *this, peer_cfg_t *peer_cfg, child_cfg_t *child_cfg,
|
||||
+ host_t *my_host, host_t *other_host,
|
||||
+ controller_cb_t callback, void *param, level_t max_level, u_int timeout,
|
||||
+ bool limits)
|
||||
{
|
||||
interface_job_t *job;
|
||||
status_t status;
|
||||
@@ -523,6 +550,8 @@ METHOD(controller_t, initiate, status_t,
|
||||
.status = FAILED,
|
||||
.child_cfg = child_cfg,
|
||||
.peer_cfg = peer_cfg,
|
||||
+ .my_host = my_host ? my_host->clone(my_host) : NULL,
|
||||
+ .other_host = other_host ? other_host->clone(other_host) : NULL,
|
||||
.lock = spinlock_create(),
|
||||
.options.limits = limits,
|
||||
},
|
||||
@@ -770,6 +799,7 @@ controller_t *controller_create(void)
|
||||
.public = {
|
||||
.create_ike_sa_enumerator = _create_ike_sa_enumerator,
|
||||
.initiate = _initiate,
|
||||
+ .initiate2 = _initiate2,
|
||||
.terminate_ike = _terminate_ike,
|
||||
.terminate_child = _terminate_child,
|
||||
.destroy = _destroy,
|
||||
diff --git a/src/libcharon/control/controller.h b/src/libcharon/control/controller.h
|
||||
index 36a1d46317..f5c60e2e72 100644
|
||||
--- a/src/libcharon/control/controller.h
|
||||
+++ b/src/libcharon/control/controller.h
|
||||
@@ -98,6 +98,34 @@ struct controller_t {
|
||||
controller_cb_t callback, void *param,
|
||||
level_t max_level, u_int timeout, bool limits);
|
||||
|
||||
+ /**
|
||||
+ * Initiate a CHILD_SA, and if required, an IKE_SA.
|
||||
+ *
|
||||
+ * If a callback is provided the function is synchronous and thus blocks
|
||||
+ * until the IKE_SA is established or failed.
|
||||
+ *
|
||||
+ * @param peer_cfg peer_cfg to use for IKE_SA setup
|
||||
+ * @param child_cfg optional child_cfg to set up CHILD_SA from
|
||||
+ * @param my_host optional address hint for source
|
||||
+ * @param other_host optional address hint for destination
|
||||
+ * @param cb logging callback
|
||||
+ * @param param parameter to include in each call of cb
|
||||
+ * @param max_level maximum log level for which cb is invoked
|
||||
+ * @param timeout timeout in ms to wait for callbacks, 0 to disable
|
||||
+ * @param limits whether to check limits regarding IKE_SA initiation
|
||||
+ * @return
|
||||
+ * - SUCCESS, if CHILD_SA established
|
||||
+ * - FAILED, if setup failed
|
||||
+ * - NEED_MORE, if callback returned FALSE
|
||||
+ * - OUT_OF_RES if timed out
|
||||
+ * - INVALID_STATE if limits prevented initiation
|
||||
+ */
|
||||
+ status_t (*initiate2)(controller_t *this,
|
||||
+ peer_cfg_t *peer_cfg, child_cfg_t *child_cfg,
|
||||
+ host_t *my_host, host_t *other_host,
|
||||
+ controller_cb_t callback, void *param,
|
||||
+ level_t max_level, u_int timeout, bool limits);
|
||||
+
|
||||
/**
|
||||
* Terminate an IKE_SA and all of its CHILD_SAs.
|
||||
*
|
||||
diff --git a/src/libcharon/plugins/vici/vici_control.c b/src/libcharon/plugins/vici/vici_control.c
|
||||
index 1c236d2491..932d0cb5a8 100644
|
||||
--- a/src/libcharon/plugins/vici/vici_control.c
|
||||
+++ b/src/libcharon/plugins/vici/vici_control.c
|
||||
@@ -1,4 +1,6 @@
|
||||
/*
|
||||
+ * Copyright (C) 2023 Zoran Peričić <zpericic@netst.org>
|
||||
+ * Copyright (C) 2014 Timo Teräs <timo.teras@iki.fi>
|
||||
* Copyright (C) 2015-2017 Tobias Brunner
|
||||
* Copyright (C) 2014 Martin Willi
|
||||
*
|
||||
@@ -173,9 +175,12 @@ static child_cfg_t* find_child_cfg(char *name, char *pname, peer_cfg_t **out)
|
||||
CALLBACK(initiate, vici_message_t*,
|
||||
private_vici_control_t *this, char *name, u_int id, vici_message_t *request)
|
||||
{
|
||||
+ vici_message_t* msg;
|
||||
peer_cfg_t *peer_cfg = NULL;
|
||||
child_cfg_t *child_cfg;
|
||||
char *child, *ike, *type, *sa;
|
||||
+ host_t *my_host = NULL, *other_host = NULL;
|
||||
+ char *my_host_str, *other_host_str;
|
||||
int timeout;
|
||||
bool limits;
|
||||
controller_cb_t log_cb = NULL;
|
||||
@@ -189,6 +194,8 @@ CALLBACK(initiate, vici_message_t*,
|
||||
timeout = request->get_int(request, 0, "timeout");
|
||||
limits = request->get_bool(request, FALSE, "init-limits");
|
||||
log.level = request->get_int(request, 1, "loglevel");
|
||||
+ my_host_str = request->get_str(request, NULL, "my-host");
|
||||
+ other_host_str = request->get_str(request, NULL, "other-host");
|
||||
|
||||
if (!child && !ike)
|
||||
{
|
||||
@@ -202,28 +209,48 @@ CALLBACK(initiate, vici_message_t*,
|
||||
type = child ? "CHILD_SA" : "IKE_SA";
|
||||
sa = child ?: ike;
|
||||
|
||||
+ if (my_host_str)
|
||||
+ {
|
||||
+ my_host = host_create_from_string(my_host_str, 0);
|
||||
+ }
|
||||
+ if (other_host_str)
|
||||
+ {
|
||||
+ other_host = host_create_from_string(other_host_str, 0);
|
||||
+ }
|
||||
+
|
||||
+ DBG1(DBG_CFG, "vici initiate %s '%s', me %H, other %H, limits %d", type, sa, my_host, other_host, limits);
|
||||
+
|
||||
child_cfg = find_child_cfg(child, ike, &peer_cfg);
|
||||
|
||||
- DBG1(DBG_CFG, "vici initiate %s '%s'", type, sa);
|
||||
if (!peer_cfg)
|
||||
{
|
||||
- return send_reply(this, "%s config '%s' not found", type, sa);
|
||||
+ msg = send_reply(this, "%s config '%s' not found", type, sa);
|
||||
+ goto ret;
|
||||
}
|
||||
- switch (charon->controller->initiate(charon->controller, peer_cfg, child_cfg,
|
||||
+ switch (charon->controller->initiate2(charon->controller, peer_cfg, child_cfg,
|
||||
+ my_host, other_host,
|
||||
log_cb, &log, log.level, timeout, limits))
|
||||
{
|
||||
case SUCCESS:
|
||||
- return send_reply(this, NULL);
|
||||
+ msg = send_reply(this, NULL);
|
||||
+ break;
|
||||
case OUT_OF_RES:
|
||||
- return send_reply(this, "%s '%s' not established after %dms", type,
|
||||
+ msg = send_reply(this, "%s '%s' not established after %dms", type,
|
||||
sa, timeout);
|
||||
+ break;
|
||||
case INVALID_STATE:
|
||||
- return send_reply(this, "establishing %s '%s' not possible at the "
|
||||
+ msg = send_reply(this, "establishing %s '%s' not possible at the "
|
||||
"moment due to limits", type, sa);
|
||||
+ break;
|
||||
case FAILED:
|
||||
default:
|
||||
- return send_reply(this, "establishing %s '%s' failed", type, sa);
|
||||
+ msg = send_reply(this, "establishing %s '%s' failed", type, sa);
|
||||
+ break;
|
||||
}
|
||||
+ret:
|
||||
+ if (my_host) my_host->destroy(my_host);
|
||||
+ if (other_host) other_host->destroy(other_host);
|
||||
+ return msg;
|
||||
}
|
||||
|
||||
/**
|
||||
diff --git a/src/libcharon/sa/ike_sa_manager.c b/src/libcharon/sa/ike_sa_manager.c
|
||||
index 7763ae844e..cf53e9ae00 100644
|
||||
--- a/src/libcharon/sa/ike_sa_manager.c
|
||||
+++ b/src/libcharon/sa/ike_sa_manager.c
|
||||
@@ -1,5 +1,7 @@
|
||||
/*
|
||||
* Copyright (C) 2008-2022 Tobias Brunner
|
||||
+ * Copyright (C) 2023 Zoran Peričić <zpericic@netst.org>
|
||||
+ * Copyright (C) 2014 Timo Teräs <timo.teras@iki.fi>
|
||||
* Copyright (C) 2005-2011 Martin Willi
|
||||
* Copyright (C) 2005 Jan Hutter
|
||||
*
|
||||
@@ -1499,6 +1501,13 @@ typedef struct {
|
||||
|
||||
METHOD(ike_sa_manager_t, checkout_by_config, ike_sa_t*,
|
||||
private_ike_sa_manager_t *this, peer_cfg_t *peer_cfg)
|
||||
+{
|
||||
+ return this->public.checkout_by_config2(&this->public, peer_cfg, NULL, NULL);
|
||||
+}
|
||||
+
|
||||
+METHOD(ike_sa_manager_t, checkout_by_config2, ike_sa_t*,
|
||||
+ private_ike_sa_manager_t *this, peer_cfg_t *peer_cfg,
|
||||
+ host_t *my_host, host_t *other_host)
|
||||
{
|
||||
enumerator_t *enumerator;
|
||||
entry_t *entry;
|
||||
@@ -1509,7 +1518,16 @@ METHOD(ike_sa_manager_t, checkout_by_config, ike_sa_t*,
|
||||
u_int segment;
|
||||
int i;
|
||||
|
||||
- DBG2(DBG_MGR, "checkout IKE_SA by config");
|
||||
+ if (my_host && my_host->get_port(my_host) == 0)
|
||||
+ {
|
||||
+ my_host->set_port(my_host, IKEV2_UDP_PORT);
|
||||
+ }
|
||||
+ if (other_host && other_host->get_port(other_host) == 0)
|
||||
+ {
|
||||
+ other_host->set_port(other_host, IKEV2_UDP_PORT);
|
||||
+ }
|
||||
+ DBG2(DBG_MGR, "checkout IKE_SA by config '%s', me %H, other %H",
|
||||
+ peer_cfg->get_name(peer_cfg), my_host, other_host);
|
||||
|
||||
if (!this->reuse_ikesa && peer_cfg->get_ike_version(peer_cfg) != IKEV1)
|
||||
{ /* IKE_SA reuse disabled by config (not possible for IKEv1) */
|
||||
@@ -1567,6 +1585,15 @@ METHOD(ike_sa_manager_t, checkout_by_config, ike_sa_t*,
|
||||
continue;
|
||||
}
|
||||
|
||||
+ if (my_host && !my_host->ip_equals(my_host, entry->ike_sa->get_my_host(entry->ike_sa)))
|
||||
+ {
|
||||
+ continue;
|
||||
+ }
|
||||
+ if (other_host && !other_host->ip_equals(other_host, entry->ike_sa->get_other_host(entry->ike_sa)))
|
||||
+ {
|
||||
+ continue;
|
||||
+ }
|
||||
+
|
||||
current_peer = entry->ike_sa->get_peer_cfg(entry->ike_sa);
|
||||
if (current_peer && current_peer->equals(current_peer, peer_cfg))
|
||||
{
|
||||
@@ -1593,6 +1620,10 @@ METHOD(ike_sa_manager_t, checkout_by_config, ike_sa_t*,
|
||||
{
|
||||
ike_sa->set_peer_cfg(ike_sa, peer_cfg);
|
||||
checkout_new(this, ike_sa);
|
||||
+ if (my_host || other_host)
|
||||
+ {
|
||||
+ ike_sa->update_hosts(ike_sa, my_host, other_host, TRUE);
|
||||
+ }
|
||||
}
|
||||
}
|
||||
charon->bus->set_sa(charon->bus, ike_sa);
|
||||
@@ -2558,6 +2589,7 @@ ike_sa_manager_t *ike_sa_manager_create()
|
||||
.checkout = _checkout,
|
||||
.checkout_by_message = _checkout_by_message,
|
||||
.checkout_by_config = _checkout_by_config,
|
||||
+ .checkout_by_config2 = _checkout_by_config2,
|
||||
.checkout_by_id = _checkout_by_id,
|
||||
.checkout_by_name = _checkout_by_name,
|
||||
.new_initiator_spi = _new_initiator_spi,
|
||||
diff --git a/src/libcharon/sa/ike_sa_manager.h b/src/libcharon/sa/ike_sa_manager.h
|
||||
index 004cc22168..d001f5a802 100644
|
||||
--- a/src/libcharon/sa/ike_sa_manager.h
|
||||
+++ b/src/libcharon/sa/ike_sa_manager.h
|
||||
@@ -123,7 +123,8 @@ struct ike_sa_manager_t {
|
||||
ike_sa_t* (*checkout_by_message) (ike_sa_manager_t* this, message_t *message);
|
||||
|
||||
/**
|
||||
- * Checkout an IKE_SA for initiation by a peer_config.
|
||||
+ * Checkout an IKE_SA for initiation by a peer_config and optional
|
||||
+ * source and remote host addresses.
|
||||
*
|
||||
* To initiate, a CHILD_SA may be established within an existing IKE_SA.
|
||||
* This call checks for an existing IKE_SA by comparing the configuration.
|
||||
@@ -140,6 +141,28 @@ struct ike_sa_manager_t {
|
||||
*/
|
||||
ike_sa_t *(*checkout_by_config)(ike_sa_manager_t* this, peer_cfg_t *peer_cfg);
|
||||
|
||||
+ /**
|
||||
+ * Checkout an IKE_SA for initiation by a peer_config and optional
|
||||
+ * source and remote host addresses.
|
||||
+ *
|
||||
+ * To initiate, a CHILD_SA may be established within an existing IKE_SA.
|
||||
+ * This call checks for an existing IKE_SA by comparing the configuration.
|
||||
+ * If the CHILD_SA can be created in an existing IKE_SA, the matching SA
|
||||
+ * is returned.
|
||||
+ * If no IKE_SA is found, a new one is created and registered in the
|
||||
+ * manager. This is also the case when the found IKE_SA is in an unusable
|
||||
+ * state (e.g. DELETING).
|
||||
+ *
|
||||
+ * @note The peer_config is always set on the returned IKE_SA.
|
||||
+ *
|
||||
+ * @param peer_cfg configuration used to find an existing IKE_SA
|
||||
+ * @param my_host source host address for wildcard peer_cfg
|
||||
+ * @param other_host remote host address for wildcard peer_cfg
|
||||
+ * @return checked out/created IKE_SA
|
||||
+ */
|
||||
+ ike_sa_t *(*checkout_by_config2)(ike_sa_manager_t* this, peer_cfg_t *peer_cfg,
|
||||
+ host_t *my_host, host_t *other_host);
|
||||
+
|
||||
/**
|
||||
* Reset initiator SPI.
|
||||
*
|
||||
diff --git a/src/libcharon/sa/trap_manager.c b/src/libcharon/sa/trap_manager.c
|
||||
index 1b85c66a5b..bbc480c0cd 100644
|
||||
--- a/src/libcharon/sa/trap_manager.c
|
||||
+++ b/src/libcharon/sa/trap_manager.c
|
||||
@@ -523,7 +523,7 @@ METHOD(trap_manager_t, acquire, void,
|
||||
peer_cfg_t *peer;
|
||||
child_cfg_t *child;
|
||||
ike_sa_t *ike_sa;
|
||||
- host_t *host;
|
||||
+ host_t *host, *my_host = NULL, *other_host = NULL;
|
||||
uint32_t allocated_reqid;
|
||||
bool wildcard, ignore = FALSE;
|
||||
|
||||
@@ -603,36 +603,26 @@ METHOD(trap_manager_t, acquire, void,
|
||||
this->lock->unlock(this->lock);
|
||||
|
||||
if (wildcard)
|
||||
- { /* the peer config would match IKE_SAs with other peers */
|
||||
- ike_sa = charon->ike_sa_manager->create_new(charon->ike_sa_manager,
|
||||
- peer->get_ike_version(peer), TRUE);
|
||||
- if (ike_sa)
|
||||
- {
|
||||
- ike_cfg_t *ike_cfg;
|
||||
- uint16_t port;
|
||||
- uint8_t mask;
|
||||
-
|
||||
- ike_sa->set_peer_cfg(ike_sa, peer);
|
||||
- ike_cfg = ike_sa->get_ike_cfg(ike_sa);
|
||||
+ {
|
||||
+ ike_cfg_t *ike_cfg;
|
||||
+ uint16_t port;
|
||||
+ uint8_t mask;
|
||||
|
||||
- port = ike_cfg->get_other_port(ike_cfg);
|
||||
- data->dst->to_subnet(data->dst, &host, &mask);
|
||||
- host->set_port(host, port);
|
||||
- ike_sa->set_other_host(ike_sa, host);
|
||||
+ ike_cfg = peer->get_ike_cfg(peer);
|
||||
|
||||
- port = ike_cfg->get_my_port(ike_cfg);
|
||||
- data->src->to_subnet(data->src, &host, &mask);
|
||||
- host->set_port(host, port);
|
||||
- ike_sa->set_my_host(ike_sa, host);
|
||||
+ port = ike_cfg->get_other_port(ike_cfg);
|
||||
+ data->dst->to_subnet(data->dst, &other_host, &mask);
|
||||
+ other_host->set_port(other_host, port);
|
||||
|
||||
- charon->bus->set_sa(charon->bus, ike_sa);
|
||||
- }
|
||||
- }
|
||||
- else
|
||||
- {
|
||||
- ike_sa = charon->ike_sa_manager->checkout_by_config(
|
||||
- charon->ike_sa_manager, peer);
|
||||
+ port = ike_cfg->get_my_port(ike_cfg);
|
||||
+ data->src->to_subnet(data->src, &my_host, &mask);
|
||||
+ my_host->set_port(my_host, port);
|
||||
}
|
||||
+ ike_sa = charon->ike_sa_manager->checkout_by_config2(
|
||||
+ charon->ike_sa_manager, peer,
|
||||
+ my_host, other_host);
|
||||
+ if (my_host) my_host->destroy(my_host);
|
||||
+ if (other_host) other_host->destroy(other_host);
|
||||
peer->destroy(peer);
|
||||
|
||||
if (ike_sa)
|
||||
diff --git a/src/swanctl/commands/initiate.c b/src/swanctl/commands/initiate.c
|
||||
index e0fffb907d..c0fc8c5952 100644
|
||||
--- a/src/swanctl/commands/initiate.c
|
||||
+++ b/src/swanctl/commands/initiate.c
|
||||
@@ -1,4 +1,5 @@
|
||||
/*
|
||||
+ * Copyright (C) 2014 Timo Teräs <timo.teras@iki.fi>
|
||||
* Copyright (C) 2014 Martin Willi
|
||||
*
|
||||
* Copyright (C) secunet Security Networks AG
|
||||
@@ -38,7 +39,7 @@ static int initiate(vici_conn_t *conn)
|
||||
vici_req_t *req;
|
||||
vici_res_t *res;
|
||||
command_format_options_t format = COMMAND_FORMAT_NONE;
|
||||
- char *arg, *child = NULL, *ike = NULL;
|
||||
+ char *arg, *child = NULL, *ike = NULL, *my_host = NULL, *other_host = NULL;
|
||||
int ret = 0, timeout = 0, level = 1;
|
||||
|
||||
while (TRUE)
|
||||
@@ -65,6 +66,12 @@ static int initiate(vici_conn_t *conn)
|
||||
case 'l':
|
||||
level = atoi(arg);
|
||||
continue;
|
||||
+ case 'S':
|
||||
+ my_host = arg;
|
||||
+ continue;
|
||||
+ case 'R':
|
||||
+ other_host = arg;
|
||||
+ continue;
|
||||
case EOF:
|
||||
break;
|
||||
default:
|
||||
@@ -88,6 +95,14 @@ static int initiate(vici_conn_t *conn)
|
||||
{
|
||||
vici_add_key_valuef(req, "ike", "%s", ike);
|
||||
}
|
||||
+ if (my_host)
|
||||
+ {
|
||||
+ vici_add_key_valuef(req, "my-host", "%s", my_host);
|
||||
+ }
|
||||
+ if (other_host)
|
||||
+ {
|
||||
+ vici_add_key_valuef(req, "other-host", "%s", other_host);
|
||||
+ }
|
||||
if (timeout)
|
||||
{
|
||||
vici_add_key_valuef(req, "timeout", "%d", timeout * 1000);
|
||||
@@ -134,6 +149,8 @@ static void __attribute__ ((constructor))reg()
|
||||
{"help", 'h', 0, "show usage information"},
|
||||
{"child", 'c', 1, "initiate a CHILD_SA configuration"},
|
||||
{"ike", 'i', 1, "initiate an IKE_SA, or name of child's parent"},
|
||||
+ {"source", 'S', 1, "override source address"},
|
||||
+ {"remote", 'R', 1, "override remote address"},
|
||||
{"timeout", 't', 1, "timeout in seconds before detaching"},
|
||||
{"raw", 'r', 0, "dump raw response message"},
|
||||
{"pretty", 'P', 0, "dump raw response message in pretty print"},
|
||||
--
|
||||
2.49.0
|
||||
|
||||
140
0002-vici-send-certificates-for-ike-sa-events.patch
Normal file
140
0002-vici-send-certificates-for-ike-sa-events.patch
Normal file
@@ -0,0 +1,140 @@
|
||||
From f6210f6ab72ead26a24a8f231eee67948d3ca543 Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Timo=20Ter=C3=A4s?= <timo.teras@iki.fi>
|
||||
Date: Mon, 21 Sep 2015 13:42:05 +0300
|
||||
Subject: [PATCH 2/4] vici: send certificates for ike-sa events
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
|
||||
---
|
||||
src/libcharon/plugins/vici/vici_query.c | 50 +++++++++++++++++++++----
|
||||
1 file changed, 42 insertions(+), 8 deletions(-)
|
||||
|
||||
diff --git a/src/libcharon/plugins/vici/vici_query.c b/src/libcharon/plugins/vici/vici_query.c
|
||||
index bacb7b101e..19acc0789b 100644
|
||||
--- a/src/libcharon/plugins/vici/vici_query.c
|
||||
+++ b/src/libcharon/plugins/vici/vici_query.c
|
||||
@@ -402,7 +402,7 @@ static void list_vips(private_vici_query_t *this, vici_builder_t *b,
|
||||
* List details of an IKE_SA
|
||||
*/
|
||||
static void list_ike(private_vici_query_t *this, vici_builder_t *b,
|
||||
- ike_sa_t *ike_sa, time_t now)
|
||||
+ ike_sa_t *ike_sa, time_t now, bool add_certs)
|
||||
{
|
||||
time_t t;
|
||||
ike_sa_id_t *id;
|
||||
@@ -411,6 +411,8 @@ static void list_ike(private_vici_query_t *this, vici_builder_t *b,
|
||||
uint32_t if_id;
|
||||
uint16_t alg, ks;
|
||||
host_t *host;
|
||||
+ auth_cfg_t *auth_cfg;
|
||||
+ enumerator_t *enumerator;
|
||||
|
||||
b->add_kv(b, "uniqueid", "%u", ike_sa->get_unique_id(ike_sa));
|
||||
b->add_kv(b, "version", "%u", ike_sa->get_version(ike_sa));
|
||||
@@ -420,11 +422,43 @@ static void list_ike(private_vici_query_t *this, vici_builder_t *b,
|
||||
b->add_kv(b, "local-host", "%H", host);
|
||||
b->add_kv(b, "local-port", "%d", host->get_port(host));
|
||||
b->add_kv(b, "local-id", "%Y", ike_sa->get_my_id(ike_sa));
|
||||
+ if (add_certs)
|
||||
+ {
|
||||
+ enumerator = ike_sa->create_auth_cfg_enumerator(ike_sa, TRUE);
|
||||
+ if (enumerator->enumerate(enumerator, &auth_cfg))
|
||||
+ {
|
||||
+ certificate_t *cert = auth_cfg->get(auth_cfg, AUTH_RULE_SUBJECT_CERT);
|
||||
+ chunk_t encoding;
|
||||
+
|
||||
+ if (cert && cert->get_encoding(cert, CERT_ASN1_DER, &encoding))
|
||||
+ {
|
||||
+ b->add(b, VICI_KEY_VALUE, "local-cert-data", encoding);
|
||||
+ free(encoding.ptr);
|
||||
+ }
|
||||
+ }
|
||||
+ enumerator->destroy(enumerator);
|
||||
+ }
|
||||
|
||||
host = ike_sa->get_other_host(ike_sa);
|
||||
b->add_kv(b, "remote-host", "%H", host);
|
||||
b->add_kv(b, "remote-port", "%d", host->get_port(host));
|
||||
b->add_kv(b, "remote-id", "%Y", ike_sa->get_other_id(ike_sa));
|
||||
+ if (add_certs)
|
||||
+ {
|
||||
+ enumerator = ike_sa->create_auth_cfg_enumerator(ike_sa, FALSE);
|
||||
+ if (enumerator->enumerate(enumerator, &auth_cfg))
|
||||
+ {
|
||||
+ certificate_t *cert = auth_cfg->get(auth_cfg, AUTH_RULE_SUBJECT_CERT);
|
||||
+ chunk_t encoding;
|
||||
+
|
||||
+ if (cert && cert->get_encoding(cert, CERT_ASN1_DER, &encoding))
|
||||
+ {
|
||||
+ b->add(b, VICI_KEY_VALUE, "remote-cert-data", encoding);
|
||||
+ free(encoding.ptr);
|
||||
+ }
|
||||
+ }
|
||||
+ enumerator->destroy(enumerator);
|
||||
+ }
|
||||
|
||||
eap = ike_sa->get_other_eap_id(ike_sa);
|
||||
|
||||
@@ -556,7 +590,7 @@ CALLBACK(list_sas, vici_message_t*,
|
||||
b = vici_builder_create();
|
||||
b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
|
||||
- list_ike(this, b, ike_sa, now);
|
||||
+ list_ike(this, b, ike_sa, now, TRUE);
|
||||
|
||||
b->begin_section(b, "child-sas");
|
||||
csas = ike_sa->create_child_sa_enumerator(ike_sa);
|
||||
@@ -1774,7 +1808,7 @@ METHOD(listener_t, ike_updown, bool,
|
||||
}
|
||||
|
||||
b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
- list_ike(this, b, ike_sa, now);
|
||||
+ list_ike(this, b, ike_sa, now, up);
|
||||
b->end_section(b);
|
||||
|
||||
this->dispatcher->raise_event(this->dispatcher,
|
||||
@@ -1799,10 +1833,10 @@ METHOD(listener_t, ike_rekey, bool,
|
||||
b = vici_builder_create();
|
||||
b->begin_section(b, old->get_name(old));
|
||||
b->begin_section(b, "old");
|
||||
- list_ike(this, b, old, now);
|
||||
+ list_ike(this, b, old, now, TRUE);
|
||||
b->end_section(b);
|
||||
b->begin_section(b, "new");
|
||||
- list_ike(this, b, new, now);
|
||||
+ list_ike(this, b, new, now, TRUE);
|
||||
b->end_section(b);
|
||||
b->end_section(b);
|
||||
|
||||
@@ -1833,7 +1867,7 @@ METHOD(listener_t, ike_update, bool,
|
||||
b->add_kv(b, "remote-port", "%d", remote->get_port(remote));
|
||||
|
||||
b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
- list_ike(this, b, ike_sa, now);
|
||||
+ list_ike(this, b, ike_sa, now, TRUE);
|
||||
b->end_section(b);
|
||||
|
||||
this->dispatcher->raise_event(this->dispatcher,
|
||||
@@ -1863,7 +1897,7 @@ METHOD(listener_t, child_updown, bool,
|
||||
}
|
||||
|
||||
b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
- list_ike(this, b, ike_sa, now);
|
||||
+ list_ike(this, b, ike_sa, now, up);
|
||||
b->begin_section(b, "child-sas");
|
||||
|
||||
snprintf(buf, sizeof(buf), "%s-%u", child_sa->get_name(child_sa),
|
||||
@@ -1898,7 +1932,7 @@ METHOD(listener_t, child_rekey, bool,
|
||||
b = vici_builder_create();
|
||||
|
||||
b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
- list_ike(this, b, ike_sa, now);
|
||||
+ list_ike(this, b, ike_sa, now, TRUE);
|
||||
b->begin_section(b, "child-sas");
|
||||
|
||||
b->begin_section(b, old->get_name(old));
|
||||
--
|
||||
2.49.0
|
||||
|
||||
160
0003-vici-add-support-for-individual-sa-state-changes.patch
Normal file
160
0003-vici-add-support-for-individual-sa-state-changes.patch
Normal file
@@ -0,0 +1,160 @@
|
||||
From effc140ed0ed5c7f1897c8abb6364d2d4789a4ee Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Timo=20Ter=C3=A4s?= <timo.teras@iki.fi>
|
||||
Date: Mon, 21 Sep 2015 13:42:11 +0300
|
||||
Subject: [PATCH 3/4] vici: add support for individual sa state changes
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
Useful for monitoring and tracking full SA.
|
||||
|
||||
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
|
||||
---
|
||||
src/libcharon/plugins/vici/vici_query.c | 106 ++++++++++++++++++++++++
|
||||
1 file changed, 106 insertions(+)
|
||||
|
||||
diff --git a/src/libcharon/plugins/vici/vici_query.c b/src/libcharon/plugins/vici/vici_query.c
|
||||
index 19acc0789b..fa1aca9536 100644
|
||||
--- a/src/libcharon/plugins/vici/vici_query.c
|
||||
+++ b/src/libcharon/plugins/vici/vici_query.c
|
||||
@@ -1774,8 +1774,16 @@ static void manage_commands(private_vici_query_t *this, bool reg)
|
||||
this->dispatcher->manage_event(this->dispatcher, "ike-updown", reg);
|
||||
this->dispatcher->manage_event(this->dispatcher, "ike-rekey", reg);
|
||||
this->dispatcher->manage_event(this->dispatcher, "ike-update", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "ike-state-established", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "ike-state-destroying", reg);
|
||||
this->dispatcher->manage_event(this->dispatcher, "child-updown", reg);
|
||||
this->dispatcher->manage_event(this->dispatcher, "child-rekey", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-installing", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-installed", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-updating", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-rekeying", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-rekeyed", reg);
|
||||
+ this->dispatcher->manage_event(this->dispatcher, "child-state-destroying", reg);
|
||||
manage_command(this, "list-sas", list_sas, reg);
|
||||
manage_command(this, "list-policies", list_policies, reg);
|
||||
manage_command(this, "list-conns", list_conns, reg);
|
||||
@@ -1876,6 +1884,46 @@ METHOD(listener_t, ike_update, bool,
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
+
|
||||
+METHOD(listener_t, ike_state_change, bool,
|
||||
+ private_vici_query_t *this, ike_sa_t *ike_sa, ike_sa_state_t state)
|
||||
+{
|
||||
+ char *event;
|
||||
+ vici_builder_t *b;
|
||||
+ time_t now;
|
||||
+
|
||||
+ switch (state)
|
||||
+ {
|
||||
+ case IKE_ESTABLISHED:
|
||||
+ event = "ike-state-established";
|
||||
+ break;
|
||||
+ case IKE_DESTROYING:
|
||||
+ event = "ike-state-destroying";
|
||||
+ break;
|
||||
+ default:
|
||||
+ return TRUE;
|
||||
+ }
|
||||
+
|
||||
+ if (!this->dispatcher->has_event_listeners(this->dispatcher, event))
|
||||
+ {
|
||||
+ return TRUE;
|
||||
+ }
|
||||
+
|
||||
+ now = time_monotonic(NULL);
|
||||
+
|
||||
+ b = vici_builder_create();
|
||||
+ b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
+ list_ike(this, b, ike_sa, now, state != IKE_DESTROYING);
|
||||
+ b->begin_section(b, "child-sas");
|
||||
+ b->end_section(b);
|
||||
+ b->end_section(b);
|
||||
+
|
||||
+ this->dispatcher->raise_event(this->dispatcher,
|
||||
+ event, 0, b->finalize(b));
|
||||
+
|
||||
+ return TRUE;
|
||||
+}
|
||||
+
|
||||
METHOD(listener_t, child_updown, bool,
|
||||
private_vici_query_t *this, ike_sa_t *ike_sa, child_sa_t *child_sa, bool up)
|
||||
{
|
||||
@@ -1955,6 +2003,62 @@ METHOD(listener_t, child_rekey, bool,
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
+METHOD(listener_t, child_state_change, bool,
|
||||
+ private_vici_query_t *this, ike_sa_t *ike_sa, child_sa_t *child_sa, child_sa_state_t state)
|
||||
+{
|
||||
+ char *event;
|
||||
+ vici_builder_t *b;
|
||||
+ time_t now;
|
||||
+
|
||||
+ switch (state)
|
||||
+ {
|
||||
+ case CHILD_INSTALLING:
|
||||
+ event = "child-state-installing";
|
||||
+ break;
|
||||
+ case CHILD_INSTALLED:
|
||||
+ event = "child-state-installed";
|
||||
+ break;
|
||||
+ case CHILD_UPDATING:
|
||||
+ event = "child-state-updating";
|
||||
+ break;
|
||||
+ case CHILD_REKEYING:
|
||||
+ event = "child-state-rekeying";
|
||||
+ break;
|
||||
+ case CHILD_REKEYED:
|
||||
+ event = "child-state-rekeyed";
|
||||
+ break;
|
||||
+ case CHILD_DESTROYING:
|
||||
+ event = "child-state-destroying";
|
||||
+ break;
|
||||
+ default:
|
||||
+ return TRUE;
|
||||
+ }
|
||||
+
|
||||
+ if (!this->dispatcher->has_event_listeners(this->dispatcher, event))
|
||||
+ {
|
||||
+ return TRUE;
|
||||
+ }
|
||||
+
|
||||
+ now = time_monotonic(NULL);
|
||||
+
|
||||
+ b = vici_builder_create();
|
||||
+ b->begin_section(b, ike_sa->get_name(ike_sa));
|
||||
+ list_ike(this, b, ike_sa, now, state != CHILD_DESTROYING);
|
||||
+ b->begin_section(b, "child-sas");
|
||||
+
|
||||
+ b->begin_section(b, child_sa->get_name(child_sa));
|
||||
+ list_child(this, b, child_sa, now);
|
||||
+ b->end_section(b);
|
||||
+
|
||||
+ b->end_section(b);
|
||||
+ b->end_section(b);
|
||||
+
|
||||
+ this->dispatcher->raise_event(this->dispatcher,
|
||||
+ event, 0, b->finalize(b));
|
||||
+
|
||||
+ return TRUE;
|
||||
+}
|
||||
+
|
||||
METHOD(vici_query_t, destroy, void,
|
||||
private_vici_query_t *this)
|
||||
{
|
||||
@@ -1975,8 +2079,10 @@ vici_query_t *vici_query_create(vici_dispatcher_t *dispatcher)
|
||||
.ike_updown = _ike_updown,
|
||||
.ike_rekey = _ike_rekey,
|
||||
.ike_update = _ike_update,
|
||||
+ .ike_state_change = _ike_state_change,
|
||||
.child_updown = _child_updown,
|
||||
.child_rekey = _child_rekey,
|
||||
+ .child_state_change = _child_state_change,
|
||||
},
|
||||
.destroy = _destroy,
|
||||
},
|
||||
--
|
||||
2.49.0
|
||||
|
||||
286
0004-Support-GRE-key-in-selectors-with-kernel-netlink.patch
Normal file
286
0004-Support-GRE-key-in-selectors-with-kernel-netlink.patch
Normal file
@@ -0,0 +1,286 @@
|
||||
From 7f32aed540533e50fa05486df471ef3c19879324 Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Zoran=20Peri=C4=8Di=C4=87?= <zoran.pericic@infomaas.com>
|
||||
Date: Sun, 21 Jan 2024 03:11:32 +0100
|
||||
Subject: [PATCH 4/4] Support GRE key in selectors with kernel-netlink.
|
||||
|
||||
Implementation use two 2-byte port fields (from/to range) to store key
|
||||
similar to ICMP.
|
||||
---
|
||||
.../kernel_netlink/kernel_netlink_ipsec.c | 19 +++++++++++++
|
||||
.../plugins/load_tester/load_tester_config.c | 22 ++++++++++++++-
|
||||
src/libcharon/plugins/stroke/stroke_config.c | 22 ++++++++++++++-
|
||||
src/libcharon/plugins/vici/vici_config.c | 27 ++++++++++++++++++-
|
||||
.../selectors/traffic_selector.c | 20 ++++++++++++++
|
||||
.../selectors/traffic_selector.h | 12 +++++++++
|
||||
src/starter/confread.c | 24 ++++++++++++++++-
|
||||
src/swanctl/swanctl.opt | 3 +++
|
||||
8 files changed, 145 insertions(+), 4 deletions(-)
|
||||
|
||||
diff --git a/src/libcharon/plugins/kernel_netlink/kernel_netlink_ipsec.c b/src/libcharon/plugins/kernel_netlink/kernel_netlink_ipsec.c
|
||||
index db0b2ac37a..d4f9571817 100644
|
||||
--- a/src/libcharon/plugins/kernel_netlink/kernel_netlink_ipsec.c
|
||||
+++ b/src/libcharon/plugins/kernel_netlink/kernel_netlink_ipsec.c
|
||||
@@ -864,6 +864,7 @@ static struct xfrm_selector ts2selector(traffic_selector_t *src,
|
||||
{
|
||||
struct xfrm_selector sel;
|
||||
uint16_t port;
|
||||
+ uint32_t gre_key;
|
||||
|
||||
memset(&sel, 0, sizeof(sel));
|
||||
sel.family = (src->get_type(src) == TS_IPV4_ADDR_RANGE) ? AF_INET : AF_INET6;
|
||||
@@ -884,6 +885,24 @@ static struct xfrm_selector ts2selector(traffic_selector_t *src,
|
||||
sel.dport = htons(traffic_selector_icmp_code(port));
|
||||
sel.dport_mask = sel.dport ? ~0 : 0;
|
||||
}
|
||||
+ if (sel.proto == IPPROTO_GRE)
|
||||
+ {
|
||||
+ /* the kernel expects the GRE key in the source and destination
|
||||
+ * port fields, respectively. */
|
||||
+ gre_key = htons(traffic_selector_gre_key(dst->get_from_port(dst), dst->get_to_port(dst)));
|
||||
+ if ( gre_key != 0 )
|
||||
+ {
|
||||
+ sel.sport = gre_key >> 16;
|
||||
+ sel.sport_mask = ~0;
|
||||
+ sel.dport = gre_key & 0xffff;
|
||||
+ sel.dport_mask = ~0;
|
||||
+ } else {
|
||||
+ sel.sport = 0;
|
||||
+ sel.sport_mask = 0;
|
||||
+ sel.dport = 0;
|
||||
+ sel.dport_mask = 0;
|
||||
+ }
|
||||
+ }
|
||||
sel.ifindex = interface ? if_nametoindex(interface) : 0;
|
||||
sel.user = 0;
|
||||
|
||||
diff --git a/src/libcharon/plugins/load_tester/load_tester_config.c b/src/libcharon/plugins/load_tester/load_tester_config.c
|
||||
index 58e1cd98a0..f20fdae522 100644
|
||||
--- a/src/libcharon/plugins/load_tester/load_tester_config.c
|
||||
+++ b/src/libcharon/plugins/load_tester/load_tester_config.c
|
||||
@@ -498,7 +498,27 @@ static bool parse_protoport(char *token, uint16_t *from_port,
|
||||
*protocol = (uint8_t)p;
|
||||
}
|
||||
}
|
||||
- if (streq(port, "%any"))
|
||||
+ if (*protocol == IPPROTO_GRE)
|
||||
+ {
|
||||
+ if (*port && !streq(port, "%any"))
|
||||
+ {
|
||||
+ p = strtol(port, &endptr, 0);
|
||||
+ if (p < 0 || p > 0xffffffff)
|
||||
+ {
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ *from_port = (p >> 16) & 0xffff;
|
||||
+ *to_port = p & 0xffff;
|
||||
+ if (*endptr)
|
||||
+ {
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ } else {
|
||||
+ *from_port = 0;
|
||||
+ *to_port = 0;
|
||||
+ }
|
||||
+ }
|
||||
+ else if (streq(port, "%any"))
|
||||
{
|
||||
*from_port = 0;
|
||||
*to_port = 0xffff;
|
||||
diff --git a/src/libcharon/plugins/stroke/stroke_config.c b/src/libcharon/plugins/stroke/stroke_config.c
|
||||
index 55db379ffe..b4340b8d1b 100644
|
||||
--- a/src/libcharon/plugins/stroke/stroke_config.c
|
||||
+++ b/src/libcharon/plugins/stroke/stroke_config.c
|
||||
@@ -927,7 +927,27 @@ static bool parse_protoport(char *token, uint16_t *from_port,
|
||||
*protocol = (uint8_t)p;
|
||||
}
|
||||
}
|
||||
- if (streq(port, "%any"))
|
||||
+ if (*protocol == IPPROTO_GRE)
|
||||
+ {
|
||||
+ if (*port && !streq(port, "%any"))
|
||||
+ {
|
||||
+ p = strtol(port, &endptr, 0);
|
||||
+ if (p < 0 || p > 0xffffffff)
|
||||
+ {
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ *from_port = (p >> 16) & 0xffff;
|
||||
+ *to_port = p & 0xffff;
|
||||
+ if (*endptr)
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ else
|
||||
+ {
|
||||
+ *from_port = 0;
|
||||
+ *to_port = 0;
|
||||
+ }
|
||||
+ }
|
||||
+ else if (streq(port, "%any"))
|
||||
{
|
||||
*from_port = 0;
|
||||
*to_port = 0xffff;
|
||||
diff --git a/src/libcharon/plugins/vici/vici_config.c b/src/libcharon/plugins/vici/vici_config.c
|
||||
index c858e9945c..24a254689b 100644
|
||||
--- a/src/libcharon/plugins/vici/vici_config.c
|
||||
+++ b/src/libcharon/plugins/vici/vici_config.c
|
||||
@@ -715,7 +715,27 @@ CALLBACK(parse_ts, bool,
|
||||
proto = (uint8_t)p;
|
||||
}
|
||||
}
|
||||
- if (streq(port, "opaque"))
|
||||
+ if (proto == IPPROTO_GRE)
|
||||
+ {
|
||||
+ if (*port && !streq(port, "any"))
|
||||
+ {
|
||||
+ p = strtol(port, &end, 0);
|
||||
+ if (p < 0 || p > 0xffffffff)
|
||||
+ {
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ from = (p >> 16) & 0xffff;
|
||||
+ to = p & 0xffff;
|
||||
+ if (*end)
|
||||
+ {
|
||||
+ return FALSE;
|
||||
+ }
|
||||
+ } else {
|
||||
+ from = 0;
|
||||
+ to = 0;
|
||||
+ }
|
||||
+ }
|
||||
+ else if (streq(port, "opaque"))
|
||||
{
|
||||
from = 0xffff;
|
||||
to = 0;
|
||||
@@ -752,6 +772,11 @@ CALLBACK(parse_ts, bool,
|
||||
}
|
||||
}
|
||||
}
|
||||
+ else if (proto == IPPROTO_GRE)
|
||||
+ {
|
||||
+ from = 0;
|
||||
+ to = 0;
|
||||
+ }
|
||||
if (streq(buf, "dynamic"))
|
||||
{
|
||||
ts = traffic_selector_create_dynamic(proto, from, to);
|
||||
diff --git a/src/libstrongswan/selectors/traffic_selector.c b/src/libstrongswan/selectors/traffic_selector.c
|
||||
index fe61e3768b..09757ec36f 100644
|
||||
--- a/src/libstrongswan/selectors/traffic_selector.c
|
||||
+++ b/src/libstrongswan/selectors/traffic_selector.c
|
||||
@@ -205,6 +205,18 @@ static int print_icmp(printf_hook_data_t *data, uint16_t port)
|
||||
return print_in_hook(data, "%d", type);
|
||||
}
|
||||
|
||||
+/**
|
||||
+ * Print GRE key
|
||||
+ */
|
||||
+static int print_gre(printf_hook_data_t *data, uint16_t from_port, uint16_t to_port)
|
||||
+{
|
||||
+ uint32_t gre_key;
|
||||
+
|
||||
+ gre_key = traffic_selector_gre_key(from_port, to_port);
|
||||
+
|
||||
+ return print_in_hook(data, "%d", gre_key);
|
||||
+}
|
||||
+
|
||||
/**
|
||||
* Described in header.
|
||||
*/
|
||||
@@ -319,6 +331,10 @@ int traffic_selector_printf_hook(printf_hook_data_t *data,
|
||||
{
|
||||
written += print_icmp(data, this->from_port);
|
||||
}
|
||||
+ else if (this->protocol == IPPROTO_GRE)
|
||||
+ {
|
||||
+ written += print_gre(data, this->from_port, this->to_port);
|
||||
+ }
|
||||
else
|
||||
{
|
||||
serv = getservbyport(htons(this->from_port), serv_proto);
|
||||
@@ -332,6 +348,10 @@ int traffic_selector_printf_hook(printf_hook_data_t *data,
|
||||
}
|
||||
}
|
||||
}
|
||||
+ else if (this->protocol == IPPROTO_GRE)
|
||||
+ {
|
||||
+ written += print_gre(data, this->from_port, this->to_port);
|
||||
+ }
|
||||
else if (is_opaque(this))
|
||||
{
|
||||
written += print_in_hook(data, "OPAQUE");
|
||||
diff --git a/src/libstrongswan/selectors/traffic_selector.h b/src/libstrongswan/selectors/traffic_selector.h
|
||||
index 367b4fff94..b7010e4a73 100644
|
||||
--- a/src/libstrongswan/selectors/traffic_selector.h
|
||||
+++ b/src/libstrongswan/selectors/traffic_selector.h
|
||||
@@ -272,6 +272,18 @@ static inline uint8_t traffic_selector_icmp_code(uint16_t port)
|
||||
return port & 0xff;
|
||||
}
|
||||
|
||||
+/**
|
||||
+ * Extract the GRE key from a source and destination port in host order
|
||||
+ *
|
||||
+ * @param from_port port number in host order
|
||||
+ * @param to_port port number in host order
|
||||
+ * @return GRE key
|
||||
+ */
|
||||
+static inline uint8_t traffic_selector_gre_key(uint16_t from_port, uint16_t to_port)
|
||||
+{
|
||||
+ return (from_port & 0xffff) << 16 | (to_port & 0xffff);
|
||||
+}
|
||||
+
|
||||
/**
|
||||
* Compare two traffic selectors, usable as sort function
|
||||
*
|
||||
diff --git a/src/starter/confread.c b/src/starter/confread.c
|
||||
index 5065bc369f..039b6f402b 100644
|
||||
--- a/src/starter/confread.c
|
||||
+++ b/src/starter/confread.c
|
||||
@@ -325,7 +325,29 @@ static void kw_end(starter_conn_t *conn, starter_end_t *end, kw_token_t token,
|
||||
end->protocol = (uint8_t)p;
|
||||
}
|
||||
}
|
||||
- if (streq(port, "%any"))
|
||||
+ if (end->protocol == IPPROTO_GRE)
|
||||
+ {
|
||||
+ if (*port && !streq(port, "%any"))
|
||||
+ {
|
||||
+ p = strtol(port, &endptr, 0);
|
||||
+ if (p < 0 || p > 0xffffffff)
|
||||
+ {
|
||||
+ DBG1(DBG_APP, "# bad GRE key: %s=%s", key, port);
|
||||
+ goto err;
|
||||
+ }
|
||||
+ end->from_port = (p >> 16) & 0xffff;
|
||||
+ end->to_port = p & 0xffff;
|
||||
+ if (*endptr)
|
||||
+ {
|
||||
+ DBG1(DBG_APP, "# bad GRE key: %s=%s", key, port);
|
||||
+ goto err;
|
||||
+ }
|
||||
+ } else {
|
||||
+ end->from_port = 0;
|
||||
+ end->to_port = 0;
|
||||
+ }
|
||||
+ }
|
||||
+ else if (streq(port, "%any"))
|
||||
{
|
||||
end->from_port = 0;
|
||||
end->to_port = 0xffff;
|
||||
diff --git a/src/swanctl/swanctl.opt b/src/swanctl/swanctl.opt
|
||||
index d9fd949ed1..1d63dadb89 100644
|
||||
--- a/src/swanctl/swanctl.opt
|
||||
+++ b/src/swanctl/swanctl.opt
|
||||
@@ -765,6 +765,9 @@ connections.<conn>.children.<child>.local_ts = dynamic
|
||||
value _opaque_ for RFC 4301 OPAQUE selectors. Port ranges may be specified
|
||||
as well, none of the kernel backends currently support port ranges, though.
|
||||
|
||||
+ If protocol is restricted to GRE, port restriction specifies GRE key
|
||||
+ in 32 bit numeric form eg. dynamic[gre/100].
|
||||
+
|
||||
When IKEv1 is used only the first selector is interpreted, except if
|
||||
the Cisco Unity extension plugin is used. This is due to a limitation of the
|
||||
IKEv1 protocol, which only allows a single pair of selectors per CHILD_SA.
|
||||
--
|
||||
2.49.0
|
||||
|
||||
109
strongswan-6.0.0-gcc15.patch
Normal file
109
strongswan-6.0.0-gcc15.patch
Normal file
@@ -0,0 +1,109 @@
|
||||
From cf7fb47788dfb83bb5d8bd0bffdb582e381a2f0a Mon Sep 17 00:00:00 2001
|
||||
From: Thomas Egerer <thomas.egerer@secunet.com>
|
||||
Date: Fri, 6 Sep 2024 13:29:40 +0200
|
||||
Subject: [PATCH] array: Don't use realloc() with zero size in array_compress()
|
||||
|
||||
The behavior of realloc(3) with zero size was apparently implementation
|
||||
defined. While glibc documents the behavior as equivalent to free(3),
|
||||
that might not apply to other C libraries. With C17, this behavior has
|
||||
been deprecated, and with C23, the behavior is now undefined. It's also
|
||||
why valgrind warns about this use.
|
||||
|
||||
Hence, when array_compress() would call realloc() with a zero size, we
|
||||
now call free() explicitly and set the pointer to NULL.
|
||||
|
||||
Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com>
|
||||
---
|
||||
src/libstrongswan/collections/array.c | 12 +++++++++++-
|
||||
1 file changed, 11 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/src/libstrongswan/collections/array.c b/src/libstrongswan/collections/array.c
|
||||
index 8acc8051d53..8b6c6d7397e 100644
|
||||
--- a/src/libstrongswan/collections/array.c
|
||||
+++ b/src/libstrongswan/collections/array.c
|
||||
@@ -197,7 +197,17 @@ void array_compress(array_t *array)
|
||||
}
|
||||
if (tail)
|
||||
{
|
||||
- array->data = realloc(array->data, get_size(array, array->count));
|
||||
+ size_t size = get_size(array, array->count);
|
||||
+
|
||||
+ if (size)
|
||||
+ {
|
||||
+ array->data = realloc(array->data, size);
|
||||
+ }
|
||||
+ else
|
||||
+ {
|
||||
+ free(array->data);
|
||||
+ array->data = NULL;
|
||||
+ }
|
||||
array->tail = 0;
|
||||
}
|
||||
}
|
||||
---
|
||||
|
||||
From f1f0bd9de60e2697a712e72b7ae9f79763a0901d Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Thu, 9 Jan 2025 16:05:39 +0100
|
||||
Subject: [PATCH] ctr: Remove parameter-less constructor prototype
|
||||
|
||||
Useless and causes a compiler warning/error:
|
||||
|
||||
error: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C23, conflicting with a subsequent declaration [-Werror,-Wdeprecated-non-prototype]
|
||||
---
|
||||
src/libstrongswan/plugins/ctr/ctr_ipsec_crypter.h | 5 -----
|
||||
1 file changed, 5 deletions(-)
|
||||
|
||||
diff --git a/src/libstrongswan/plugins/ctr/ctr_ipsec_crypter.h b/src/libstrongswan/plugins/ctr/ctr_ipsec_crypter.h
|
||||
index e9421a1be9f..3814465e48b 100644
|
||||
--- a/src/libstrongswan/plugins/ctr/ctr_ipsec_crypter.h
|
||||
+++ b/src/libstrongswan/plugins/ctr/ctr_ipsec_crypter.h
|
||||
@@ -37,11 +37,6 @@ struct ctr_ipsec_crypter_t {
|
||||
crypter_t crypter;
|
||||
};
|
||||
|
||||
-/**
|
||||
- * Create a ctr_ipsec_crypter instance.
|
||||
- */
|
||||
-ctr_ipsec_crypter_t *ctr_ipsec_crypter_create();
|
||||
-
|
||||
/**
|
||||
* Create a ctr_ipsec_crypter instance.
|
||||
*
|
||||
---
|
||||
|
||||
From 227d7ef9a24b8c62d6965c1c1690252bde7c698d Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Fri, 10 Jan 2025 15:43:11 +0100
|
||||
Subject: [PATCH] tnc-imv: Add missing argument to IMV recommendations
|
||||
constructor
|
||||
|
||||
This avoids the following warning/error:
|
||||
|
||||
tnc_imv_manager.c:244:39: error: passing arguments to 'tnc_imv_recommendations_create' without a prototype is deprecated in all versions of C and is not supported in C23 [-Werror,-Wdeprecated-non-prototype]
|
||||
244 | return tnc_imv_recommendations_create(this->imvs);
|
||||
| ^
|
||||
---
|
||||
src/libtnccs/plugins/tnc_imv/tnc_imv_recommendations.h | 7 +++++--
|
||||
1 file changed, 5 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/src/libtnccs/plugins/tnc_imv/tnc_imv_recommendations.h b/src/libtnccs/plugins/tnc_imv/tnc_imv_recommendations.h
|
||||
index f7178876cfd..60272978ad3 100644
|
||||
--- a/src/libtnccs/plugins/tnc_imv/tnc_imv_recommendations.h
|
||||
+++ b/src/libtnccs/plugins/tnc_imv/tnc_imv_recommendations.h
|
||||
@@ -27,8 +27,11 @@
|
||||
#include <collections/linked_list.h>
|
||||
|
||||
/**
|
||||
- * Create an IMV empty recommendations instance
|
||||
+ * Create an empty IMV recommendations instance
|
||||
+ *
|
||||
+ * @param imv_list list of IMVs that could provide recommendations
|
||||
+ * @return created instance
|
||||
*/
|
||||
-recommendations_t *tnc_imv_recommendations_create();
|
||||
+recommendations_t *tnc_imv_recommendations_create(linked_list_t *imv_list);
|
||||
|
||||
#endif /** TNC_IMV_RECOMMENDATIONS_H_ @}*/
|
||||
---
|
||||
|
||||
597
strongswan-6.0.1-gcc15.patch
Normal file
597
strongswan-6.0.1-gcc15.patch
Normal file
@@ -0,0 +1,597 @@
|
||||
From a7b5de569082398a14b7e571498e55d005903aaf Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Fri, 21 Feb 2025 17:18:35 +0100
|
||||
Subject: [PATCH] pki: Fix signature of help() to match that of a callback in
|
||||
command_t
|
||||
|
||||
---
|
||||
src/pki/command.c | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/src/pki/command.c b/src/pki/command.c
|
||||
index accec5fe51b..6e6bf041e18 100644
|
||||
--- a/src/pki/command.c
|
||||
+++ b/src/pki/command.c
|
||||
@@ -265,7 +265,7 @@ int command_usage(char *error)
|
||||
/**
|
||||
* Show usage information
|
||||
*/
|
||||
-static int help(int c, char *v[])
|
||||
+static int help()
|
||||
{
|
||||
return command_usage(NULL);
|
||||
}
|
||||
---
|
||||
|
||||
From 38d89f57f0771d3cc7b2ab70849584685ada2bc0 Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Fri, 21 Feb 2025 16:47:34 +0100
|
||||
Subject: [PATCH] charon-nm: Use CALLBACK macro for callback job's cancel
|
||||
implementation
|
||||
|
||||
Casting to this specific function type doesn't work anymore if C23 is
|
||||
used as the types mismatch.
|
||||
---
|
||||
src/charon-nm/nm/nm_backend.c | 5 +++--
|
||||
1 file changed, 3 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/src/charon-nm/nm/nm_backend.c b/src/charon-nm/nm/nm_backend.c
|
||||
index aefd3f95688..8ee1785212e 100644
|
||||
--- a/src/charon-nm/nm/nm_backend.c
|
||||
+++ b/src/charon-nm/nm/nm_backend.c
|
||||
@@ -78,7 +78,8 @@ static job_requeue_t run(nm_backend_t *this)
|
||||
/**
|
||||
* Cancel the GLib Main Event Loop
|
||||
*/
|
||||
-static bool cancel(nm_backend_t *this)
|
||||
+CALLBACK(cancel, bool,
|
||||
+ nm_backend_t *this)
|
||||
{
|
||||
if (this->loop)
|
||||
{
|
||||
@@ -152,7 +153,7 @@ static bool nm_backend_init()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)run, this,
|
||||
- NULL, (callback_job_cancel_t)cancel, JOB_PRIO_CRITICAL));
|
||||
+ NULL, cancel, JOB_PRIO_CRITICAL));
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
---
|
||||
|
||||
From d5d2568ff0e88d364dadf50b67bf17050763cf98 Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Fri, 21 Feb 2025 16:45:57 +0100
|
||||
Subject: [PATCH] callback-job: Replace return_false() in constructors with
|
||||
dedicated function
|
||||
|
||||
Besides being clearer, this fixes issues with GCC 15. The latter uses
|
||||
C23 by default, which changes the meaning of function declarations
|
||||
without parameters such as
|
||||
|
||||
bool return false();
|
||||
|
||||
Instead of "this function takes an unknown number of arguments", this
|
||||
now equals (void), that is, "this function takes no arguments". So we
|
||||
run into incompatible pointer type warnings all over when using such
|
||||
functions. They could be cast to (void*) but this seems the cleaner
|
||||
solution for this use case.
|
||||
---
|
||||
src/charon-cmd/cmd/cmd_connection.c | 2 +-
|
||||
.../jni/libandroidbridge/backend/android_dns_proxy.c | 2 +-
|
||||
.../jni/libandroidbridge/backend/android_service.c | 6 +++---
|
||||
src/libcharon/network/receiver.c | 2 +-
|
||||
src/libcharon/network/sender.c | 2 +-
|
||||
.../plugins/bypass_lan/bypass_lan_listener.c | 4 ++--
|
||||
.../plugins/eap_radius/eap_radius_accounting.c | 2 +-
|
||||
src/libcharon/plugins/eap_radius/eap_radius_plugin.c | 2 +-
|
||||
src/libcharon/plugins/ha/ha_ctl.c | 2 +-
|
||||
src/libcharon/plugins/ha/ha_dispatcher.c | 2 +-
|
||||
src/libcharon/plugins/ha/ha_segments.c | 6 +++---
|
||||
.../kernel_libipsec/kernel_libipsec_esp_handler.c | 2 +-
|
||||
.../plugins/kernel_libipsec/kernel_libipsec_router.c | 2 +-
|
||||
src/libcharon/plugins/smp/smp.c | 4 ++--
|
||||
src/libcharon/plugins/tnc_pdp/tnc_pdp_connections.c | 2 +-
|
||||
src/libcharon/plugins/uci/uci_control.c | 2 +-
|
||||
src/libipsec/ipsec_event_relay.c | 2 +-
|
||||
src/libipsec/ipsec_processor.c | 4 ++--
|
||||
src/libpttls/pt_tls_dispatcher.c | 2 +-
|
||||
src/libstrongswan/networking/streams/stream_service.c | 2 +-
|
||||
src/libstrongswan/processing/jobs/callback_job.c | 10 +++++++++-
|
||||
src/libstrongswan/processing/jobs/callback_job.h | 11 ++++++++++-
|
||||
src/libstrongswan/processing/scheduler.c | 3 ++-
|
||||
src/libstrongswan/processing/watcher.c | 4 ++--
|
||||
src/libtls/tests/suites/test_socket.c | 2 +-
|
||||
25 files changed, 51 insertions(+), 33 deletions(-)
|
||||
|
||||
diff --git a/src/charon-cmd/cmd/cmd_connection.c b/src/charon-cmd/cmd/cmd_connection.c
|
||||
index 8e8d8236e52..e220e33a62a 100644
|
||||
--- a/src/charon-cmd/cmd/cmd_connection.c
|
||||
+++ b/src/charon-cmd/cmd/cmd_connection.c
|
||||
@@ -585,7 +585,7 @@ cmd_connection_t *cmd_connection_create()
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio(
|
||||
(callback_job_cb_t)initiate, this, NULL,
|
||||
- (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libcharon/network/receiver.c b/src/libcharon/network/receiver.c
|
||||
index e79d5974409..480d1d622d5 100644
|
||||
--- a/src/libcharon/network/receiver.c
|
||||
+++ b/src/libcharon/network/receiver.c
|
||||
@@ -737,7 +737,7 @@ receiver_t *receiver_create()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)receive_packets,
|
||||
- this, NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ this, NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libcharon/network/sender.c b/src/libcharon/network/sender.c
|
||||
index 4543766d62e..3fcd17f1b63 100644
|
||||
--- a/src/libcharon/network/sender.c
|
||||
+++ b/src/libcharon/network/sender.c
|
||||
@@ -216,7 +216,7 @@ sender_t * sender_create()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)send_packets,
|
||||
- this, NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ this, NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libcharon/plugins/bypass_lan/bypass_lan_listener.c b/src/libcharon/plugins/bypass_lan/bypass_lan_listener.c
|
||||
index db7abd8146b..c9aed3666fc 100644
|
||||
--- a/src/libcharon/plugins/bypass_lan/bypass_lan_listener.c
|
||||
+++ b/src/libcharon/plugins/bypass_lan/bypass_lan_listener.c
|
||||
@@ -227,7 +227,7 @@ METHOD(kernel_listener_t, roam, bool,
|
||||
{
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)update_bypass, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
@@ -269,7 +269,7 @@ METHOD(bypass_lan_listener_t, reload_interfaces, void,
|
||||
this->mutex->unlock(this->mutex);
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)update_bypass, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
}
|
||||
|
||||
METHOD(bypass_lan_listener_t, destroy, void,
|
||||
diff --git a/src/libcharon/plugins/eap_radius/eap_radius_accounting.c b/src/libcharon/plugins/eap_radius/eap_radius_accounting.c
|
||||
index f833dc3c0b4..2f29d080764 100644
|
||||
--- a/src/libcharon/plugins/eap_radius/eap_radius_accounting.c
|
||||
+++ b/src/libcharon/plugins/eap_radius/eap_radius_accounting.c
|
||||
@@ -706,7 +706,7 @@ static void schedule_interim(private_eap_radius_accounting_t *this,
|
||||
(job_t*)callback_job_create_with_prio(
|
||||
(callback_job_cb_t)send_interim,
|
||||
data, (void*)destroy_interim_data,
|
||||
- (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL), tv);
|
||||
+ callback_job_cancel_thread, JOB_PRIO_CRITICAL), tv);
|
||||
}
|
||||
}
|
||||
|
||||
diff --git a/src/libcharon/plugins/eap_radius/eap_radius_plugin.c b/src/libcharon/plugins/eap_radius/eap_radius_plugin.c
|
||||
index 5051542615a..55d5e032cea 100644
|
||||
--- a/src/libcharon/plugins/eap_radius/eap_radius_plugin.c
|
||||
+++ b/src/libcharon/plugins/eap_radius/eap_radius_plugin.c
|
||||
@@ -445,7 +445,7 @@ void eap_radius_handle_timeout(ike_sa_id_t *id)
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio(
|
||||
(callback_job_cb_t)delete_all_async, NULL, NULL,
|
||||
- (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
}
|
||||
else if (id)
|
||||
{
|
||||
diff --git a/src/libcharon/plugins/ha/ha_ctl.c b/src/libcharon/plugins/ha/ha_ctl.c
|
||||
index 8859bae166b..3d2ac7de84d 100644
|
||||
--- a/src/libcharon/plugins/ha/ha_ctl.c
|
||||
+++ b/src/libcharon/plugins/ha/ha_ctl.c
|
||||
@@ -199,6 +199,6 @@ ha_ctl_t *ha_ctl_create(ha_segments_t *segments, ha_cache_t *cache)
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)dispatch_fifo,
|
||||
- this, NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ this, NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libcharon/plugins/ha/ha_dispatcher.c b/src/libcharon/plugins/ha/ha_dispatcher.c
|
||||
index 5de26a65a27..83be91ab159 100644
|
||||
--- a/src/libcharon/plugins/ha/ha_dispatcher.c
|
||||
+++ b/src/libcharon/plugins/ha/ha_dispatcher.c
|
||||
@@ -1184,7 +1184,7 @@ ha_dispatcher_t *ha_dispatcher_create(ha_socket_t *socket,
|
||||
);
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)dispatch, this,
|
||||
- NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libcharon/plugins/ha/ha_segments.c b/src/libcharon/plugins/ha/ha_segments.c
|
||||
index afb76b39ea2..32d9ee40717 100644
|
||||
--- a/src/libcharon/plugins/ha/ha_segments.c
|
||||
+++ b/src/libcharon/plugins/ha/ha_segments.c
|
||||
@@ -316,7 +316,7 @@ static void start_watchdog(private_ha_segments_t *this)
|
||||
this->heartbeat_active = TRUE;
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)watchdog, this,
|
||||
- NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
}
|
||||
|
||||
METHOD(ha_segments_t, handle_status, void,
|
||||
@@ -404,7 +404,7 @@ static void start_heartbeat(private_ha_segments_t *this)
|
||||
{
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)send_status,
|
||||
- this, NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ this, NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -451,7 +451,7 @@ static void start_autobalance(private_ha_segments_t *this)
|
||||
DBG1(DBG_CFG, "scheduling HA autobalance every %ds", this->autobalance);
|
||||
lib->scheduler->schedule_job(lib->scheduler,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)autobalance,
|
||||
- this, NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL),
|
||||
+ this, NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL),
|
||||
this->autobalance);
|
||||
}
|
||||
|
||||
diff --git a/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_esp_handler.c b/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_esp_handler.c
|
||||
index 095ad67b4b0..c18e266e4d1 100644
|
||||
--- a/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_esp_handler.c
|
||||
+++ b/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_esp_handler.c
|
||||
@@ -337,7 +337,7 @@ kernel_libipsec_esp_handler_t *kernel_libipsec_esp_handler_create()
|
||||
}
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create(send_esp, this, NULL,
|
||||
- (callback_job_cancel_t)return_false));
|
||||
+ callback_job_cancel_thread));
|
||||
return &this->public;
|
||||
}
|
||||
|
||||
diff --git a/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_router.c b/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_router.c
|
||||
index 74746e251de..07adc70be3e 100644
|
||||
--- a/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_router.c
|
||||
+++ b/src/libcharon/plugins/kernel_libipsec/kernel_libipsec_router.c
|
||||
@@ -364,7 +364,7 @@ kernel_libipsec_router_t *kernel_libipsec_router_create()
|
||||
charon->receiver->add_esp_cb(charon->receiver, receiver_esp_cb, NULL);
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)handle_plain, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
|
||||
router = &this->public;
|
||||
return &this->public;
|
||||
diff --git a/src/libcharon/plugins/smp/smp.c b/src/libcharon/plugins/smp/smp.c
|
||||
index 6ca9f13997e..85ff5830bc5 100644
|
||||
--- a/src/libcharon/plugins/smp/smp.c
|
||||
+++ b/src/libcharon/plugins/smp/smp.c
|
||||
@@ -710,7 +710,7 @@ static job_requeue_t dispatch(private_smp_t *this)
|
||||
fdp = malloc_thing(int);
|
||||
*fdp = fd;
|
||||
job = callback_job_create((callback_job_cb_t)process, fdp, free,
|
||||
- (callback_job_cancel_t)return_false);
|
||||
+ callback_job_cancel_thread);
|
||||
lib->processor->queue_job(lib->processor, (job_t*)job);
|
||||
|
||||
return JOB_REQUEUE_DIRECT;
|
||||
@@ -800,7 +800,7 @@ plugin_t *smp_plugin_create()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)dispatch, this,
|
||||
- NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
|
||||
return &this->public.plugin;
|
||||
}
|
||||
diff --git a/src/libcharon/plugins/tnc_pdp/tnc_pdp_connections.c b/src/libcharon/plugins/tnc_pdp/tnc_pdp_connections.c
|
||||
index 30aeb116dec..da317a894d9 100644
|
||||
--- a/src/libcharon/plugins/tnc_pdp/tnc_pdp_connections.c
|
||||
+++ b/src/libcharon/plugins/tnc_pdp/tnc_pdp_connections.c
|
||||
@@ -210,7 +210,7 @@ METHOD(tnc_pdp_connections_t, add, void,
|
||||
/* schedule timeout checking */
|
||||
lib->scheduler->schedule_job_ms(lib->scheduler,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)check_timeouts,
|
||||
- this, NULL, (callback_job_cancel_t)return_false),
|
||||
+ this, NULL, callback_job_cancel_thread),
|
||||
this->timeout * 1000);
|
||||
|
||||
dbg_nas_user(nas_id, user_name, FALSE, "created");
|
||||
diff --git a/src/libcharon/plugins/uci/uci_control.c b/src/libcharon/plugins/uci/uci_control.c
|
||||
index b033c832c8c..8074005ee57 100644
|
||||
--- a/src/libcharon/plugins/uci/uci_control.c
|
||||
+++ b/src/libcharon/plugins/uci/uci_control.c
|
||||
@@ -296,7 +296,7 @@ uci_control_t *uci_control_create()
|
||||
{
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)receive,
|
||||
- this, NULL, (callback_job_cancel_t)return_false,
|
||||
+ this, NULL, callback_job_cancel_thread,
|
||||
JOB_PRIO_CRITICAL));
|
||||
}
|
||||
return &this->public;
|
||||
diff --git a/src/libipsec/ipsec_event_relay.c b/src/libipsec/ipsec_event_relay.c
|
||||
index 0f10795d168..802146eef21 100644
|
||||
--- a/src/libipsec/ipsec_event_relay.c
|
||||
+++ b/src/libipsec/ipsec_event_relay.c
|
||||
@@ -230,7 +230,7 @@ ipsec_event_relay_t *ipsec_event_relay_create()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)handle_events, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libipsec/ipsec_processor.c b/src/libipsec/ipsec_processor.c
|
||||
index 2572b088089..8549fefe261 100644
|
||||
--- a/src/libipsec/ipsec_processor.c
|
||||
+++ b/src/libipsec/ipsec_processor.c
|
||||
@@ -336,9 +336,9 @@ ipsec_processor_t *ipsec_processor_create()
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)process_inbound, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create((callback_job_cb_t)process_outbound, this,
|
||||
- NULL, (callback_job_cancel_t)return_false));
|
||||
+ NULL, callback_job_cancel_thread));
|
||||
return &this->public;
|
||||
}
|
||||
diff --git a/src/libpttls/pt_tls_dispatcher.c b/src/libpttls/pt_tls_dispatcher.c
|
||||
index a134bee238f..c7e42b277e1 100644
|
||||
--- a/src/libpttls/pt_tls_dispatcher.c
|
||||
+++ b/src/libpttls/pt_tls_dispatcher.c
|
||||
@@ -156,7 +156,7 @@ METHOD(pt_tls_dispatcher_t, dispatch, void,
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((callback_job_cb_t)handle,
|
||||
connection, (void*)cleanup,
|
||||
- (callback_job_cancel_t)return_false,
|
||||
+ callback_job_cancel_thread,
|
||||
JOB_PRIO_CRITICAL));
|
||||
}
|
||||
}
|
||||
diff --git a/src/libstrongswan/networking/streams/stream_service.c b/src/libstrongswan/networking/streams/stream_service.c
|
||||
index 5b709a2247d..c85a0664351 100644
|
||||
--- a/src/libstrongswan/networking/streams/stream_service.c
|
||||
+++ b/src/libstrongswan/networking/streams/stream_service.c
|
||||
@@ -221,7 +221,7 @@ static bool watch(private_stream_service_t *this, int fd, watcher_event_t event)
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((void*)accept_async, data,
|
||||
- (void*)destroy_async_data, (callback_job_cancel_t)return_false,
|
||||
+ (void*)destroy_async_data, callback_job_cancel_thread,
|
||||
this->prio));
|
||||
}
|
||||
else
|
||||
diff --git a/src/libstrongswan/processing/jobs/callback_job.c b/src/libstrongswan/processing/jobs/callback_job.c
|
||||
index cb2a0aba5b9..3ab40b947c9 100644
|
||||
--- a/src/libstrongswan/processing/jobs/callback_job.c
|
||||
+++ b/src/libstrongswan/processing/jobs/callback_job.c
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright (C) 2009-2012 Tobias Brunner
|
||||
+ * Copyright (C) 2009-2025 Tobias Brunner
|
||||
* Copyright (C) 2007-2011 Martin Willi
|
||||
*
|
||||
* Copyright (C) secunet Security Networks AG
|
||||
@@ -131,3 +131,11 @@ callback_job_t *callback_job_create(callback_job_cb_t cb, void *data,
|
||||
return callback_job_create_with_prio(cb, data, cleanup, cancel,
|
||||
JOB_PRIO_MEDIUM);
|
||||
}
|
||||
+
|
||||
+/*
|
||||
+ * Described in header
|
||||
+ */
|
||||
+bool callback_job_cancel_thread(void *data)
|
||||
+{
|
||||
+ return FALSE;
|
||||
+}
|
||||
diff --git a/src/libstrongswan/processing/jobs/callback_job.h b/src/libstrongswan/processing/jobs/callback_job.h
|
||||
index 0f1ae212d87..fda86887944 100644
|
||||
--- a/src/libstrongswan/processing/jobs/callback_job.h
|
||||
+++ b/src/libstrongswan/processing/jobs/callback_job.h
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright (C) 2012 Tobias Brunner
|
||||
+ * Copyright (C) 2012-2025 Tobias Brunner
|
||||
* Copyright (C) 2007-2011 Martin Willi
|
||||
*
|
||||
* Copyright (C) secunet Security Networks AG
|
||||
@@ -62,6 +62,15 @@ typedef void (*callback_job_cleanup_t)(void *data);
|
||||
*/
|
||||
typedef bool (*callback_job_cancel_t)(void *data);
|
||||
|
||||
+/**
|
||||
+ * Default implementation of callback_job_cancel_t that simply returns FALSE
|
||||
+ * to force cancellation of the thread by the processor.
|
||||
+ *
|
||||
+ * @param data ignored argument
|
||||
+ * @return always returns FALSE
|
||||
+ */
|
||||
+bool callback_job_cancel_thread(void *data);
|
||||
+
|
||||
/**
|
||||
* Class representing an callback Job.
|
||||
*
|
||||
diff --git a/src/libstrongswan/processing/scheduler.c b/src/libstrongswan/processing/scheduler.c
|
||||
index c5e5dd83e70..76d98ddff51 100644
|
||||
--- a/src/libstrongswan/processing/scheduler.c
|
||||
+++ b/src/libstrongswan/processing/scheduler.c
|
||||
@@ -329,7 +329,8 @@ scheduler_t * scheduler_create()
|
||||
this->heap = (event_t**)calloc(this->heap_size + 1, sizeof(event_t*));
|
||||
|
||||
job = callback_job_create_with_prio((callback_job_cb_t)schedule, this,
|
||||
- NULL, return_false, JOB_PRIO_CRITICAL);
|
||||
+ NULL, callback_job_cancel_thread,
|
||||
+ JOB_PRIO_CRITICAL);
|
||||
lib->processor->queue_job(lib->processor, (job_t*)job);
|
||||
|
||||
return &this->public;
|
||||
diff --git a/src/libstrongswan/processing/watcher.c b/src/libstrongswan/processing/watcher.c
|
||||
index 1200d670959..a86ec0910d1 100644
|
||||
--- a/src/libstrongswan/processing/watcher.c
|
||||
+++ b/src/libstrongswan/processing/watcher.c
|
||||
@@ -291,7 +291,7 @@ static void notify(private_watcher_t *this, entry_t *entry,
|
||||
|
||||
this->jobs->insert_last(this->jobs,
|
||||
callback_job_create_with_prio((void*)notify_async, data,
|
||||
- (void*)notify_end, (callback_job_cancel_t)return_false,
|
||||
+ (void*)notify_end, callback_job_cancel_thread,
|
||||
JOB_PRIO_CRITICAL));
|
||||
}
|
||||
|
||||
@@ -559,7 +559,7 @@ METHOD(watcher_t, add, void,
|
||||
|
||||
lib->processor->queue_job(lib->processor,
|
||||
(job_t*)callback_job_create_with_prio((void*)watch, this,
|
||||
- NULL, (callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
|
||||
+ NULL, callback_job_cancel_thread, JOB_PRIO_CRITICAL));
|
||||
}
|
||||
else
|
||||
{
|
||||
diff --git a/src/libtls/tests/suites/test_socket.c b/src/libtls/tests/suites/test_socket.c
|
||||
index 91ee58b975f..c17d0a8873e 100644
|
||||
--- a/src/libtls/tests/suites/test_socket.c
|
||||
+++ b/src/libtls/tests/suites/test_socket.c
|
||||
@@ -587,7 +587,7 @@ static void start_echo_server(echo_server_config_t *config)
|
||||
|
||||
lib->processor->queue_job(lib->processor, (job_t*)
|
||||
callback_job_create((void*)serve_echo, config, NULL,
|
||||
- (callback_job_cancel_t)return_false));
|
||||
+ callback_job_cancel_thread));
|
||||
}
|
||||
|
||||
/**
|
||||
---
|
||||
|
||||
From 11978ddd39e800b5f35f721d726e8a4cb7e4ec0f Mon Sep 17 00:00:00 2001
|
||||
From: Tobias Brunner <tobias@strongswan.org>
|
||||
Date: Fri, 21 Feb 2025 17:00:44 +0100
|
||||
Subject: [PATCH] Cast uses of return_*(), nop() and enumerator_create_empty()
|
||||
|
||||
As described in the previous commit, GCC 15 uses C23 by default and that
|
||||
changes the meaning of such argument-less function declarations. So
|
||||
whenever we assign such a function to a pointer that expects a function
|
||||
with arguments it causes an incompatible pointer type warning. We
|
||||
could define dedicated functions/callbacks whenever necessary, but this
|
||||
seems like the simpler approach for now (especially since most uses of
|
||||
these functions have already been cast).
|
||||
---
|
||||
src/charon-nm/nm/nm_handler.c | 2 +-
|
||||
src/libcharon/encoding/payloads/encrypted_payload.c | 2 +-
|
||||
src/libcharon/plugins/android_dns/android_dns_handler.c | 2 +-
|
||||
src/libcharon/plugins/ha/ha_attribute.c | 2 +-
|
||||
src/libcharon/plugins/updown/updown_handler.c | 2 +-
|
||||
src/libstrongswan/utils/identification.c | 6 +++---
|
||||
6 files changed, 8 insertions(+), 8 deletions(-)
|
||||
|
||||
diff --git a/src/charon-nm/nm/nm_handler.c b/src/charon-nm/nm/nm_handler.c
|
||||
index d7331ad72f6..39d0190ac9e 100644
|
||||
--- a/src/charon-nm/nm/nm_handler.c
|
||||
+++ b/src/charon-nm/nm/nm_handler.c
|
||||
@@ -195,7 +195,7 @@ nm_handler_t *nm_handler_create()
|
||||
.public = {
|
||||
.handler = {
|
||||
.handle = _handle,
|
||||
- .release = nop,
|
||||
+ .release = (void*)nop,
|
||||
.create_attribute_enumerator = _create_attribute_enumerator,
|
||||
},
|
||||
.create_enumerator = _create_enumerator,
|
||||
diff --git a/src/libcharon/encoding/payloads/encrypted_payload.c b/src/libcharon/encoding/payloads/encrypted_payload.c
|
||||
index 676d00b7a29..4821c6108ed 100644
|
||||
--- a/src/libcharon/encoding/payloads/encrypted_payload.c
|
||||
+++ b/src/libcharon/encoding/payloads/encrypted_payload.c
|
||||
@@ -1023,7 +1023,7 @@ encrypted_fragment_payload_t *encrypted_fragment_payload_create()
|
||||
.get_length = _frag_get_length,
|
||||
.add_payload = _frag_add_payload,
|
||||
.remove_payload = (void*)return_null,
|
||||
- .generate_payloads = nop,
|
||||
+ .generate_payloads = (void*)nop,
|
||||
.set_transform = _frag_set_transform,
|
||||
.get_transform = _frag_get_transform,
|
||||
.encrypt = _frag_encrypt,
|
||||
diff --git a/src/libcharon/plugins/android_dns/android_dns_handler.c b/src/libcharon/plugins/android_dns/android_dns_handler.c
|
||||
index 78f4f702aec..14d2ff99aa3 100644
|
||||
--- a/src/libcharon/plugins/android_dns/android_dns_handler.c
|
||||
+++ b/src/libcharon/plugins/android_dns/android_dns_handler.c
|
||||
@@ -191,7 +191,7 @@ METHOD(enumerator_t, enumerate_dns, bool,
|
||||
VA_ARGS_VGET(args, type, data);
|
||||
*type = INTERNAL_IP4_DNS;
|
||||
*data = chunk_empty;
|
||||
- this->venumerate = return_false;
|
||||
+ this->venumerate = (void*)return_false;
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
diff --git a/src/libcharon/plugins/ha/ha_attribute.c b/src/libcharon/plugins/ha/ha_attribute.c
|
||||
index b865a4b829b..103d1a93784 100644
|
||||
--- a/src/libcharon/plugins/ha/ha_attribute.c
|
||||
+++ b/src/libcharon/plugins/ha/ha_attribute.c
|
||||
@@ -381,7 +381,7 @@ ha_attribute_t *ha_attribute_create(ha_kernel_t *kernel, ha_segments_t *segments
|
||||
.provider = {
|
||||
.acquire_address = _acquire_address,
|
||||
.release_address = _release_address,
|
||||
- .create_attribute_enumerator = enumerator_create_empty,
|
||||
+ .create_attribute_enumerator = (void*)enumerator_create_empty,
|
||||
},
|
||||
.reserve = _reserve,
|
||||
.destroy = _destroy,
|
||||
diff --git a/src/libcharon/plugins/updown/updown_handler.c b/src/libcharon/plugins/updown/updown_handler.c
|
||||
index 36eb15615a4..3707e1e658c 100644
|
||||
--- a/src/libcharon/plugins/updown/updown_handler.c
|
||||
+++ b/src/libcharon/plugins/updown/updown_handler.c
|
||||
@@ -220,7 +220,7 @@ updown_handler_t *updown_handler_create()
|
||||
.handler = {
|
||||
.handle = _handle,
|
||||
.release = _release,
|
||||
- .create_attribute_enumerator = enumerator_create_empty,
|
||||
+ .create_attribute_enumerator = (void*)enumerator_create_empty,
|
||||
},
|
||||
.create_dns_enumerator = _create_dns_enumerator,
|
||||
.destroy = _destroy,
|
||||
diff --git a/src/libstrongswan/utils/identification.c b/src/libstrongswan/utils/identifi
|
||||
100 5229 100 5229 0 0 26091 0 --:--:-- --:--:-- --:--:-- 26145
|
||||
cation.c
|
||||
index d31955b3806..58a05052dc1 100644
|
||||
--- a/src/libstrongswan/utils/identification.c
|
||||
+++ b/src/libstrongswan/utils/identification.c
|
||||
@@ -1625,7 +1625,7 @@ static private_identification_t *identification_create(id_type_t type)
|
||||
this->public.hash = _hash_binary;
|
||||
this->public.equals = _equals_binary;
|
||||
this->public.matches = _matches_any;
|
||||
- this->public.contains_wildcards = return_true;
|
||||
+ this->public.contains_wildcards = (void*)return_true;
|
||||
break;
|
||||
case ID_FQDN:
|
||||
case ID_RFC822_ADDR:
|
||||
@@ -1660,13 +1660,13 @@ static private_identification_t *identification_create(id_type_t type)
|
||||
this->public.hash = _hash_binary;
|
||||
this->public.equals = _equals_binary;
|
||||
this->public.matches = _matches_range;
|
||||
- this->public.contains_wildcards = return_false;
|
||||
+ this->public.contains_wildcards = (void*)return_false;
|
||||
break;
|
||||
default:
|
||||
this->public.hash = _hash_binary;
|
||||
this->public.equals = _equals_binary;
|
||||
this->public.matches = _matches_binary;
|
||||
- this->public.contains_wildcards = return_false;
|
||||
+ this->public.contains_wildcards = (void*)return_false;
|
||||
break;
|
||||
}
|
||||
return this;
|
||||
@@ -1,5 +1,6 @@
|
||||
%global _hardened_build 1
|
||||
#%%define prerelease dr1
|
||||
%global dist .nhrp.11%{?dist}
|
||||
|
||||
%bcond_without python3
|
||||
%bcond_without perl
|
||||
@@ -29,6 +30,13 @@ Source3: tmpfiles-strongswan.conf
|
||||
Patch0: strongswan-5.6.0-uintptr_t.patch
|
||||
# https://github.com/strongswan/strongswan/issues/1198
|
||||
Patch1: strongswan-5.9.7-error-no-format.patch
|
||||
Patch2: strongswan-6.0.0-gcc15.patch
|
||||
Patch3: strongswan-6.0.1-gcc15.patch
|
||||
|
||||
Patch10: 0001-charon-add-optional-source-and-remote-overrides-for-.patch
|
||||
Patch11: 0002-vici-send-certificates-for-ike-sa-events.patch
|
||||
Patch12: 0003-vici-add-support-for-individual-sa-state-changes.patch
|
||||
Patch13: 0004-Support-GRE-key-in-selectors-with-kernel-netlink.patch
|
||||
|
||||
BuildRequires: autoconf
|
||||
BuildRequires: automake
|
||||
@@ -154,7 +162,7 @@ for Strongswan runtime configuration from perl applications.
|
||||
|
||||
%build
|
||||
# only for snapshots
|
||||
#autoreconf
|
||||
autoreconf
|
||||
|
||||
# --with-ipsecdir moves internal commands to /usr/libexec/strongswan
|
||||
# --bindir moves 'pki' command to /usr/libexec/strongswan
|
||||
|
||||
Reference in New Issue
Block a user